Add scalar_override example to File Upload #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an example of setting a scalar override in order to get the correct type annotation of the runtime type of the Upload scalar
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
|
Hi 👋 You can find a preview of the docs here: https://beta.strawberry.rocks/docs/pr/3389/guides/file-upload |
|
@jonfinerty great addition, I wonder if should do this automatically based on the current framework? /cc @erikwrede @bellini666 |
Probably we should :) |
patrick91
approved these changes
Mar 30, 2024
|
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example of setting a scalar override in order to get the correct type annotation of the runtime type of the Upload scalar to the documentation, something which took me a while to work out myself. I don't know if it's worth the update, but would have saved me half an hour.
I don't think your adding RELEASE.md's for doc changes, but happy to add one if this is accepted.
Description
Short documentation about how to get file upload type annotations working based on the particular integration your using.
Types of Changes
Checklist