Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix info by adding a custom
__class_getitem__
#3419Fix info by adding a custom
__class_getitem__
#3419Changes from all commits
a22a502
49bd118
2fbea94
5508f44
23639fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Consider adding a test case for error conditions.
It would be beneficial to include a test case that verifies the behavior when invalid types are passed to
strawberry.Info
. This could help ensure that the custom__class_getitem__
method handles error conditions gracefully.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Add a test case for using
strawberry.Info
without any arguments.Including a test case for
strawberry.Info
invoked without any arguments could verify that the default behavior aligns with expectations. This scenario seems to be missing and could be an important edge case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise (testing): Praise for covering both one and two argument use cases.
The inclusion of tests for both one and two argument scenarios for
strawberry.Info
is commendable. It ensures that the functionality works as expected in these common use cases.