Fix GET requests with content_type headers

[vethan]

Description

Currently, if you perform a GET query while supplying the application/json header, strawberry will return a 400. By moving the method check first when parsing the query we can avoid these unneccessary 400s

Types of Changes

• Core
• [ x] Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

• Issue not created

Checklist

• [x ] My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• [ x] I have read the CONTRIBUTING document.
• [ x] I have added tests to cover my changes.
• [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[sourcery-ai]

Hey @vethan - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Docstrings: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

This change fixes GET request queries returning a 400 if a content_type header is supplied

Here's the tweet text:

🆕 Release (next) is out! Thanks to @vethan4 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

[codecov]

Codecov Report

Merging #3452 (3327afd) into main (292b771) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3452      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.01%     
==========================================
  Files         509      509              
  Lines       32717    32723       +6     
  Branches     5404     5404              
==========================================
+ Hits        31566    31571       +5     
- Misses        940      941       +1     
  Partials      211      211              

[codspeed-hq]

CodSpeed Performance Report

Merging #3452 will degrade performances by 26.72%

_{Comparing vethan:get-method-check-should-be-first (53e3874) with main (292b771)}

Summary

❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	vethan:get-method-check-should-be-first	Change
❌	test_execute_basic	10.2 ms	13.9 ms	-26.72%

[patrick91]

Ah! interesting!

The changes look good, but could you add a test? let me know if you need any info 😊

[vethan]

Ah! interesting!

The changes look good, but could you add a test? let me know if you need any info 😊

@patrick91 Test Added!

[patrick91]

Perfect, thank you!

[botberry]

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥