Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix specialize_type_vars resolution for generic aliases #3535

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

bellini666
Copy link
Member

While trying to debug strawberry-graphql/strawberry-django#535 I discovered this.

There's still another bug on strawberry-django itself, but it needs this to be fixed first.

@bellini666 bellini666 self-assigned this Jun 7, 2024
@botberry
Copy link
Member

botberry commented Jun 7, 2024

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release fixes an issue when trying to retrieve specialized type vars from a
generic type that has been aliased to a name, in cases like:

@strawberry.type
class Fruit(Generic[T]): ...


SpecializedFruit = Fruit[str]

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #3535 will not alter performance

Comparing specialized_type_var_map_for_aliases (4abca0d) with main (d934bfc)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.35%. Comparing base (d934bfc) to head (4abca0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3535      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%     
==========================================
  Files         519      519              
  Lines       32318    32334      +16     
  Branches     3701     3703       +2     
==========================================
+ Hits        30494    30509      +15     
+ Misses       1542     1541       -1     
- Partials      282      284       +2     

@bellini666 bellini666 merged commit a58fdf5 into main Jun 7, 2024
64 checks passed
@bellini666 bellini666 deleted the specialized_type_var_map_for_aliases branch June 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants