add an aws chalice integration #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding the Here's a preview of the changelog: This release adds support for AWS Chalice. A framework for deploying serverless applications using AWS. A view for aws chalice has been added to the strawberry codebase. Here's the preview release card for twitter: Here's the tweet text: |
BryceBeagle
requested changes
May 9, 2021
Co-authored-by: ignormies <bryce.beagle@gmail.com>
Co-authored-by: ignormies <bryce.beagle@gmail.com>
update to main
Co-authored-by: ignormies <bryce.beagle@gmail.com>
Co-authored-by: ignormies <bryce.beagle@gmail.com>
BryceBeagle
requested changes
Jul 8, 2021
mcsheehan
force-pushed
the
feature/chalice
branch
from
8a29719
to
2edd4d3
Compare
Updated release notes and added chalice as a dev dependency Added catching the json_body value error and removed unused type error TypeError must be caught here as they payload might not be json Removed the separate get and post methods Added the chalice integration to the docs Update docs/integrations/chalice.md Added the suggestion to remove $ from the shell commands to be consistent Co-authored-by: ignormies <bryce.beagle@gmail.com> Update docs/integrations/chalice.md Co-authored-by: ignormies <bryce.beagle@gmail.com> Update strawberry/chalice/views.py Co-authored-by: ignormies <bryce.beagle@gmail.com> Update docs/integrations/chalice.md Co-authored-by: ignormies <bryce.beagle@gmail.com> Update docs/integrations/chalice.md Co-authored-by: ignormies <bryce.beagle@gmail.com> Update docs/integrations/chalice.md Co-authored-by: ignormies <bryce.beagle@gmail.com> Added a response type to the documentation
mcsheehan
force-pushed
the
feature/chalice
branch
from
2edd4d3
to
5c360a5
Compare
BryceBeagle
approved these changes
Jul 24, 2021
|
This may require a few changes if #1066 is merged first |
As a result of the unit tests have handled the BadRequestError returned by chalice and mapped that to a graphql style error response with status code 200.
for more information, see https://pre-commit.ci
Removed the untested line from views and added a default argument instead
patrick91
reviewed
Nov 23, 2021
|
I'll merge this after I fix the mypy issue :D |
patrick91
force-pushed
the
feature/chalice
branch
2 times, most recently
from
3ce08d1
to
492ba72
Compare
patrick91
force-pushed
the
feature/chalice
branch
from
492ba72
to
5cb5f78
Compare
Apparently mypy has some issues when using classes inside functions, as we do in our tests, issue here: python/mypy#6422
|
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an aws chalice integration with unit tests.
A server can be launched from the tests directory by making a chalice config and then running chalice local. The unit tests capture the usage of chalice.
Closes #845