Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists are broken and empty after latest commits #1430

Closed
3 tasks done
nokia8801 opened this issue Apr 23, 2024 · 5 comments
Closed
3 tasks done

Playlists are broken and empty after latest commits #1430

nokia8801 opened this issue Apr 23, 2024 · 5 comments
Assignees

Comments

@nokia8801
Copy link

nokia8801 commented Apr 23, 2024

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
Playlists are broken and empty after the latest commits. The tracks are still there but they have no information about them and can't be played.

To Reproduce
Clone the repo and compile from master.

Expected behavior
Should be visible and working like before. It was working with version 1.0.23.r116.gc30a39d2-1 which would be commit c30a39d.

Screenshots:
image

System Information:

  • Operating system: Arch Linux
  • Strawberry Version: 1.0.23.r145.g426de615-1 | commit 426de61
  • Qt 6.7.0 with qt6-wayland
  • GNOME 46.1 on Wayland

Additional context
Not every playlist is broken like this for some reason, but more than half are empty. Either it is random or there is something I'm not understanding. But downloading normal 1.0.23 from official Arch repositories fixes the issue so it must be one the recent commits, probably between ac0926d and 5f9a838 (including them) cause it first broke with commit 5f9a838 and is still broken even with the latest commits.

@jonaski
Copy link
Member

jonaski commented Apr 23, 2024

Thanks, I see the col position is wrong, will look into it.

@jonaski
Copy link
Member

jonaski commented Apr 23, 2024

The position was wrong when loading streams and songs outside of the collection. Should be fixed now, but your playlists will probably already be wiped so you need to recreate them.

@nokia8801
Copy link
Author

nokia8801 commented Apr 23, 2024

Should be fixed now, but your playlists will probably already be wiped so you need to recreate them.

@jonaski Downgrading to regular 1.0.23 brought them back somehow. I just compiled strawberry-git again and local songs are back to normal but url streams are still broken and can't be played. They're completely empty and when I click them I get:

Invalid URI "".

../gstreamer/subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c(1683): gen_source_element (): /GstPlayBin3:pipeline-3-pipeline/GstURIDecodeBin3:uridecodebin3/GstURISourceBin:urisourcebin2

Edit: Nevermind, added them again and everything is fine, they must be broken leftovers from the previous commits. Thanks again.

Edit: Actually, do not nevermind. After closing the app and reopening it, the URL streams break again. They're empty and can't played.

@jonaski
Copy link
Member

jonaski commented Apr 23, 2024

I forgot that radio streams has it's own playlist item type, fixed now.

@cmorgenstern
Copy link

Sorry to necro-bump, but I don't think this has been resolved. Using the latest version of Strawberry compiled from master, playlists with local files do not correctly display, and I cannot save and load playlists either (M3U).

Describe the bug
Local tracks in playlists are not correctly linked to library items.
Loading a newly saved M3U playlist also produces the same result.

To Reproduce

  1. Open Strawberry
  2. Open an M3U playlist containing local track

Expected:
Playlist loads with the entries linked to tracks in the library

Actual:
Playlist entries are not linked and cannot be played.

  1. Open Strawberry
  2. Create a new playlist and and add some tracks
  3. Save the playlist (.m3u) and close it
  4. Load the saved playlist

Expected:
Playlist loads with the entries linked to tracks in the library

Actual:
Playlist entries are not linked and cannot be played.

System Information:

  • Operating system: Arch Linux
  • Strawberry Version: 1.0.23.r174.g9f2e4ac3-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants