Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter playlists by rating #1212

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Dakes
Copy link
Contributor

@Dakes Dakes commented Jun 6, 2023

This adds the ability to filter your playlists by rating in two different ways.
For example you can filter by 0-5 Stars like this:
rating:5 rating:>=3 rating:!=0
Or use float values from 0-1 with a prefixed "f":
rating:f1 rating:>f0.5

The implementation got a little messy, unfortunately. But it works.

Copy link
Member

@jonaski jonaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you squash the 2 correction commits into the first one, and if you rebase with master it should also fix the CI issue.

Playlists can now be filtered by the rating from 0-5 like:
rating:0 rating:<3 rating:!=0
or by a float value, like:
rating:f0.1 rating:>=f0.5
@Dakes
Copy link
Contributor Author

Dakes commented Jun 7, 2023

I think it is looking good now. ✌️

@Dakes Dakes requested a review from jonaski June 9, 2023 10:24
@jonaski jonaski merged commit 1deacae into strawberrymusicplayer:master Jun 9, 2023
@Dakes
Copy link
Contributor Author

Dakes commented Jun 9, 2023

Thank you. I appreciate your work. Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants