Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate URI before attempting to use it #241

Merged
merged 2 commits into from Mar 3, 2017
Merged

Validate URI before attempting to use it #241

merged 2 commits into from Mar 3, 2017

Conversation

michaelklishin
Copy link
Collaborator

References #202, whether this validation is sufficient is up for debate.

@michaelklishin michaelklishin mentioned this pull request Feb 24, 2017
Closed
@gerhard
Error if URI contains whitespaces
02d73c5 
We do not want to make any assumptions whether the whitespace is
genuinely required or not. If it is, escape it (e.g. %20). If it isn't,
we might have caught an inccorectly defined URI.
gerhard
gerhard reviewed Mar 3, 2017
View reviewed changes
Copy link
Collaborator

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url.Parse is already validating the URL through url.parse. I'm thinking that tackling #202 head-on would be best. What do you think?

@michaelklishin
Copy link
Collaborator Author

@gerhard no objections.

@gerhard gerhard merged commit 9a99f3d into master Mar 3, 2017
@gerhard gerhard deleted the issue-202-uri-validation branch March 3, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhard gerhard gerhard left review comments

@streadway streadway Awaiting requested review from streadway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelklishin @gerhard