Application testable Delivery - API Change #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Ack/Nack/Reject to the Channel * Add Delivery.Acknowledger interface delegating to the channel * Drop Delivery.Cancel By using an Acknowledger delegate, it remains possible to multiplex deliveries from multiple channels to the same handler without requiring the application to keep a reverse mapping from delivery back to the source channel for the common case of Acks. Application tests can now simulate deliveries, and track acknowledgments per source channel via a custom implementation. Remove the `Cancel` delegate in Delivery. Use the Channel directly to cancel a subscription. To handle Cancel, including other richer interactions with the Channel in application consumers, the channel reference should be passed along with the delivery in an application specific type to the consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #64
By using an Acknowledger delegate, it remains possible to multiplex
deliveries from multiple channels to the same handler without requiring
the application to keep a reverse mapping from delivery back to the
source channel for the common case of Acks.
Application tests can now simulate deliveries, and track acknowledgments
per source channel via a custom implementation.
Remove the
Canceldelegate in Delivery. Use the Channel directly tocancel a subscription.
To handle Cancel, including other richer interactions with the Channel
in application consumers, the channel reference should be passed along
with the delivery in an application specific type to the consumer.