Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for allowing mvn build of java and react-api via github actions #1

Merged
merged 9 commits into from
Jul 7, 2023

Conversation

ssharan22
Copy link
Collaborator

  • moved mvnw to root project level
  • modified root project name to arrakis
  • added build and package changes to bundle react static assets to be served via spring boot
  • modified github actions to use mvnw
  • removed package-lock.json

Copy link
Collaborator

@peterrhysthomas peterrhysthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks very much

@peterrhysthomas peterrhysthomas merged commit 8e55f5c into main Jul 7, 2023
1 check passed
@ssharan22 ssharan22 deleted the feature/create-github-action-mvn-clean-build branch July 9, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants