init/instance/nwjs: don't store maximized state

See #1009
streamlink · May 16, 2024 · 25e7432 · 25e7432
1 parent 5ee7ac9
commit 25e7432
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/app/init/instance-initializers/nwjs/window.js b/src/app/init/instance-initializers/nwjs/window.js
@@ -79,6 +79,10 @@ function onMove( windowRecord, x, y ) {
 }
 
 function onMaximize( windowRecord, maximized ) {
+	// HACK: the window `restore` event does not trigger on NW.js >=0.80,<0.84,
+	// causing the window state to become broken (see #1015):
+	// Don't store the maximized state for now
+	maximized = false;
 	return save( windowRecord, { maximized } );
 }
 

diff --git a/src/test/tests/init/instance-initializers/nwjs/window.js b/src/test/tests/init/instance-initializers/nwjs/window.js
@@ -448,7 +448,7 @@ module( "init/instance-initializers/nwjs/window", function( hooks ) {
 				y: 270,
 				width: 960,
 				height: 540,
-				maximized: true
+				maximized: false // FIXME: restore this
 			},
 			"Saves maximized state on maximize"
 		);
@@ -609,7 +609,7 @@ module( "init/instance-initializers/nwjs/window", function( hooks ) {
 				y: 0,
 				width: 1920,
 				height: 1080,
-				maximized: true
+				maximized: false // FIXME: restore this
 			},
 			"Updates the window record only after the event ignore time expires"
 		);