Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window restore event doesn't trigger when unmaximizing #1009

Closed
4 tasks done
cadbusca opened this issue May 12, 2024 · 4 comments
Closed
4 tasks done

Window restore event doesn't trigger when unmaximizing #1009

cadbusca opened this issue May 12, 2024 · 4 comments

Comments

@cadbusca
Copy link

Checklist

Streamlink Twitch GUI version

v2.5.1

Streamlink version

No response

Operating system, environment and configuration details

Manjaro Linux / KDE / X11

Description

Clicking on the '-' and '+' buttons sometimes works as expected, but, most of the time it doesn't (has no effect).

The issue is not consistent and start happening after clicking a few times on those buttons or interacting with the UI.
Right after opening Streamlink Twitch GUI It usually works fine, then you open a stream and after a while decide to use those buttons and the issue starts to happen.
Double-clicking the app's header bar fix the issue for a while, but not permanently.

This issue does not happen on v2.4.1

Debug log

No response

@cadbusca cadbusca changed the title Clicking on the Minimize ('-') or Maximize ('+') buttons sometimes has no effect Clicking the Minimize ('-') or Maximize ('+') buttons sometimes has no effect May 12, 2024
@bastimeyer
Copy link
Member

No reason to open another issue for this. I am aware and have already explained it in #1008.
There will be a downgrade to NW.js 0.80 which will resolve the issue.

@bastimeyer bastimeyer closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@cadbusca
Copy link
Author

Thanks

@bastimeyer bastimeyer reopened this May 16, 2024
@bastimeyer bastimeyer changed the title Clicking the Minimize ('-') or Maximize ('+') buttons sometimes has no effect Window restore event doesn't trigger when unmaximizing May 16, 2024
@bastimeyer
Copy link
Member

The issue currently can't be fixed. Please see the linked NW.js versions meta thread above...

For now, I've disabled storing the maximized window state, so that the app doesn't launch maximized. If you want to unmaximize the window, double-click the window drag area or use your system's window manager. The maximize button depends on the internal window state, which is broken due to an NW.js issue.

@bastimeyer
Copy link
Member

Resolved by 381a9a5 / ab45651
See #1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants