Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n/zh-cn: Add Simplified Chinese translation #958

Merged
merged 1 commit into from Apr 5, 2023
Merged

i18n/zh-cn: Add Simplified Chinese translation #958

merged 1 commit into from Apr 5, 2023

Conversation

dreammu
Copy link
Contributor

@dreammu dreammu commented Apr 4, 2023

Some words are difficult to find appropriate translations for in Chinese, but the ones provided should be enough.

Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the effort of adding a new translation, @dreammu. Much appreciated.

There are two minor issues in the locales.json file which I've annotated. I also have two questions regarding the translations themselves.

I obviously can't comment on the translations, but if there's anything which was unclear during the translation due to missing context, etc., I'll be happy to help clarify.

I also checked for any layout issues, but everything looked fine. The language selection in the settings menu is currently not ordered correctly, but that's because of 17f01c2 which I will fix after this one got merged.

src/config/locales.json Outdated Show resolved Hide resolved
src/config/locales.json Outdated Show resolved Hide resolved
src/app/locales/zh-cn/models.yml Outdated Show resolved Hide resolved
src/app/locales/zh-cn/components.yml Outdated Show resolved Hide resolved
@bastimeyer bastimeyer added the i18n label Apr 4, 2023
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pluralization issue left. Once fixed, I'll have a final review later today and will then merge.
Thanks again.

src/app/locales/zh-cn/routes.yml Outdated Show resolved Hide resolved
@bastimeyer bastimeyer merged commit 4968497 into streamlink:master Apr 5, 2023
6 checks passed
@bastimeyer
Copy link
Member

Thanks again, @dreammu.

I locally rebased your commits onto master for final testing, squashed the commits and then force-pushed onto your branch, so that I didn't have to squash via the GH interface.

@dreammu dreammu deleted the i18n/zh-cn branch April 5, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants