plugins.twitch: fix call_subdomain

[EnterGin]

fixes #2751

[codecov]

Codecov Report

Merging #2958 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2958      +/-   ##
==========================================
- Coverage   52.61%   52.59%   -0.03%     
==========================================
  Files         251      251              
  Lines       15756    15762       +6     
==========================================
  Hits         8290     8290              
- Misses       7466     7472       +6     

[bastimeyer]

Thanks for taking the time finding the issue.
Ideally the whole call_subdomain method should get removed, as the API hostname could also be set as a parameter in the regular call method, which would be way more clear, but that's not important now. A simple try/finally block is enough.

[bastimeyer]

Suggested change

	try:
	response = self.call(path, format=format, schema=schema, **extra_params)
	except PluginError:
	self.subdomain = subdomain_buffer
	raise
	self.subdomain = subdomain_buffer
	return response
	try:
	return self.call(path, format=format, schema=schema, **extra_params)
	finally:
	self.subdomain = subdomain_buffer

[bastimeyer]

That's not the diff I suggested. You are writing duplicate code.

[EnterGin]

That's not the diff I suggested. You are writing duplicate code.

Oh, you about removing call_subdomain at all?

[bastimeyer]

diff

#2958 (comment)

[EnterGin]

OK, I got it, sorry.