-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about dropping old Windows support #3327
Conversation
@@ -40,6 +40,12 @@ Portable See the `Windows portable version`_ section | |||
|
|||
.. _Installing Winget packages: https://docs.microsoft.com/en-us/windows/package-manager/ | |||
|
|||
.. note:: | |||
|
|||
As of Streamlink version 2.0.0 this software will no longer operate on Windows 7 or Windows Vista. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically it is just the installer, not Streamlink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the version installed by the installer ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I had written yesterday before committing my changes:
diff --git a/docs/install.rst b/docs/install.rst
index 59382d5b..78453020 100644
--- a/docs/install.rst
+++ b/docs/install.rst
@@ -177,6 +177,7 @@ Windows port. version RosadinTV <RosadinTV at outlook.com> |br|
beardypig <beardypig at protonmail.com>
==================================== ===========================================
+.. _PyPI package and source code:
PyPI package and source code
----------------------------
@@ -285,6 +286,8 @@ using `virtualenv`_, which creates a user owned Python environment instead.
.. _virtualenv: https://virtualenv.readthedocs.io/en/latest/
+.. _Dependencies:
+
Dependencies
^^^^^^^^^^^^
@@ -357,6 +360,17 @@ Release Notes
See the `commit log`_ for a list of changes since the last stable release.
==================================== ====================================
+.. note::
+
+ **Both Streamlink installers for Windows require at least Windows 8.** |br|
+ Windows 7, Vista and XP are not supported due to limitations of Python 3.9+.
+
+ Be aware that the packages for `Chocolatey`_ and the `Windows Package Manager`_ are just wrappers
+ around the stable installer and thus depend on Windows 8+ as well.
+
+ Alternatively, :ref:`Streamlink can be installed via python-pip<PyPI package and source code>`
+ in a :ref:`compatible<Dependencies>` Python environment.
+
.. _Stable release:
.. _GitHub releases page: https://github.com/streamlink/streamlink/releases/latest
.. _Development build:
Instead of adding a note at the top, this adds one at the bottom where the installers are actually linked. We don't have any notes in the macOS and Linux+BSD package sections, so adding it to the bottom is much cleaner.
This note also includes links to the mentioned sections or packages. Unfortunately, the section headers had to be updated with custom reference points, because this isn't done automatically, and when adding an extension to sphinx for this auto-header-linking, other issues need to be resolved first, because there are duplicate header names.
If we decide to downgrade the installer's Python version to 3.8, the text obviously needs to be changed/corrected.
Seeing this and with reference to my comment on Gitter earlier today, would there be any value in also adding a note for Linux users, just to try and stave off any unnecessary issues when 2.0.0 is released? Perhaps something like: note: For Streamlink versions >= 2.0.0: Users of older but currently supported Linux distributions with Python 3.5 will need to install a Python package with a minimum version of 3.6 that can coexist with the system version. For Python up to version 3.9 on Ubuntu 16.04, install the PPA by following the instructions here. Then For Python up to version 3.7 on Debian Stretch, add the repository by following the instructions here. Then |
@bastimeyer Your reasoning on the section makes sense to me and the text is fine, I'll close this. |
@mkbloke No, this doesn't make much sense, as the available Streamlink packages on various Linux distros are built against the distro's default Python env. If this Python env is too old, then there won't be any new Streamlink packages available. Ubuntu 16.04 for example doesn't have any Streamlink packages, and Debian Stretch's last Streamlink package version is 1.0.0, which shows you that it's irrelevant that Python 2.7 and 3.5 have been dropped. It also doesn't matter if old distro releases which "supported" are still on Python 3.5, because this version is not maintained by the Python devs anymore. We don't need to bloat up the install docs for old and irrelevant Linux distro releases. There already is an entire section on how to install Streamlink via python-pip and in a virtualenv and it already tells the user to do this if a newer package version is not available on their distro. @gravyboat You could have just updated your PR with my diff suggestion. But since you've already closed yours and deleted your branch, I'm going to open one myself now with an updated note. |
@bastimeyer Ahh sorry I thought you already had a branch waiting and just hadn't opened the PR. |
Can't you allow Windows 7 support at least till 2023 as it's still supported by ESU updates ? |
@karlo2105 We're not going to do that. Extended security updates are typically only for businesses and they cost money. Streamlink was never intended or designed for businesses to use on their old outdated machines. If anyone is using Streamlink in a business context they can upgrade or fork us and keep 2.7 support going that way. |
@karlo2105, pip installs require Python >= 3.6. |
@karlo2105, another thought: In theory this won't really affect you anyway (for the time being, at least). The Windows installer was downgraded to Python 3,8 to allow for installation on Windows 7, it's just not officially supported by Streamlink and requires a fully patched Windows 7 system to work. |
Closes #3323