chore: remove old rtmpdump/subprocess CLI args #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/streamlink/streamlink/blob/1.7.0/win32/streamlinkrc#L48-L51 would be bad removing this |
|
Would it make sense adding a suppressed argparse argument for this and dealing with this in Btw, the entire streamlinkrc file desperately needs an overhaul. |
might be the best solution, the command itself doesn't even need to work as as long as we don't need to deal with |
and remove compat key name translations in the Session options. Removes the following CLI arguments: - `--rtmpdump-proxy` (use `--rtmp-proxy` instead) - `-c` / `--cmdline` (use `--subprocess-cmdline` instead) - `-e` / `--errorlog` (use `--subprocess-errorlog` instead) - `--erorlog-path` (use `--subprocess-errorlog-path` instead) Keeps `--rtmpdump` as a fallback for `--rtmp-rtmpdump`, as the default streamlinkrc config file of the Windows installer is still using the old parameter name.
bastimeyer
force-pushed
the
compat-removal/session-options
branch
from
3be1a84
to
2c33a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove compat key name translations in the Session options.
Removes the following CLI arguments:
--rtmpdump-proxy(use--rtmp-proxyinstead)-c/--cmdline(use--subprocess-cmdlineinstead)-e/--errorlog(use--subprocess-errorloginstead)--errorlog-path(use--subprocess-errorlog-pathinstead)Keeps
--rtmpdumpas a fallback for--rtmp-rtmpdump, as the defaultstreamlinkrc config file of the Windows installer is still using the
old parameter name.
#3235 (comment)