Enable running E2E tests from streamlit/streamlit #72
Conversation
This reverts commit aa191e9.
sfc-gh-gpijanski
force-pushed
the
separate-workflow-for-e2e
branch
from
3738ee2
to
0cf37f8
Compare
Separate building component wheels and streamlit component libraries and some fixes and refactor. Changes from
sfc-gh-gpijanski
force-pushed
the
separate-workflow-for-e2e
branch
from
cba9914
to
236cb48
Compare
sfc-gh-gpijanski
force-pushed
the
separate-workflow-for-e2e
branch
from
89d320a
to
4cf9f03
Compare
sfc-gh-gpijanski
changed the title
| inputs: | ||
| custom_streamlit_component_lib_file: | ||
| required: false | ||
| description: '' |
There was a problem hiding this comment.
Can you add a description?
.github/actions/run_e2e/action.yaml
Outdated
| shell: bash | ||
| run: | | ||
| if [ -n "${{ inputs.streamlit_version }}" ]; then | ||
| ./dev.py e2e-build-images "--streamlit-version=${{ inputs.streamlit_version }}" "--python-version=${{ inputs.python_version }}" |
There was a problem hiding this comment.
Using inputs as variables in a script is potentially dangerous because we don't know how the user will use this action. See: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
.github/actions/run_e2e/action.yaml
Outdated
|
|
||
| - name: Check prerequisite | ||
| run: | | ||
| One and exactly one input is required: streamlit_version, streamlit_wheel_file |
There was a problem hiding this comment.
| One and exactly one input is required: streamlit_version, streamlit_wheel_file | |
| echo "One and exactly one input is required: streamlit_version, streamlit_wheel_file". |
| inputs: | ||
| custom_streamlit_component_lib_file: | ||
| required: false | ||
| description: 'Streamlit Component Library package' |
There was a problem hiding this comment.
| description: 'Streamlit Component Library package' | |
| description: | | |
| Path to local Streamlit Component Library package. | |
| To generate a package, run the npm pack command in the directory with the Streamlit component library. |
|
|
||
| outputs: | ||
| output_directory: | ||
| description: '' |
There was a problem hiding this comment.
Can you add a description here also? Each description field should be filled in.
| @@ -0,0 +1,54 @@ | |||
| name: 'Build Streamlit Component Library' | |||
There was a problem hiding this comment.
This is not an unambiguous description in this context, because in the case of npm packages, building is the process of compiling Typescript code to Javascript, but we are packaging a library here.
.github/actions/run_e2e/action.yaml
Outdated
|
|
||
| inputs: | ||
| python_version: | ||
| description: 'Python version' |
There was a problem hiding this comment.
Can you add a more descriptive description?
This change enables running e2e tests on all components from streamlit/streamlit repository. It extracts:
into a separate actions.