Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to match with newest Validators version and enforce Pandas <2 until new duckdb is released #11

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Update code to match with newest Validators version and enforce Pandas <2 until new duckdb is released #11

merged 7 commits into from
Sep 26, 2023

Conversation

sfc-gh-tszerszen
Copy link
Collaborator

@sfc-gh-tszerszen sfc-gh-tszerszen commented Sep 22, 2023 •
edited
Loading

Current version of gsheets-connection is broken due to:

  • newest version of validators package renamed its functions
  • duckdb lost compatibility with pandas>=2.1.0

This PR addresses above problems by:

  • Enforcing newest validators version in setup.py and changing the gsheets-connection code to support newest API (Kudos to @sfc-gh-dmatthews for finding last working version and the reason behind the failure in the following commit.
  • Release of duckdb==0.8.1 does not support pandas>=2 so I enforced pandas <2 until duckdb==0.8.2 is released

Also this PR introduced some minor linting fixes to keep compatibility with ruff.

@sfc-gh-tszerszen sfc-gh-tszerszen self-assigned this Sep 22, 2023
@sfc-gh-tszerszen sfc-gh-tszerszen changed the title Fix ruff linting Update code to match with newest Validators version and fix Pandas 2.1 support by enforcing newest version of Duckdb Sep 22, 2023
@sfc-gh-tszerszen sfc-gh-tszerszen mentioned this pull request Sep 22, 2023
Closed
blackary
blackary reviewed Sep 22, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
blackary
blackary approved these changes Sep 22, 2023
View reviewed changes
Copy link

@blackary blackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but a couple of questions

@sfc-gh-jcarroll
Copy link
Contributor

Good by me to merge once questions from Zachary addressed. TY!!!

@sfc-gh-tszerszen
Copy link
Collaborator Author

Thank you all for the review 🙇 Please address my comment about duckdb Pandas 2 support and Streamlit compatibility and we will proceed accordingly

@sfc-gh-tszerszen sfc-gh-tszerszen merged commit e8d512f into main Sep 26, 2023
3 checks passed
@sfc-gh-tszerszen sfc-gh-tszerszen changed the title Update code to match with newest Validators version and fix Pandas 2.1 support by enforcing newest version of Duckdb Update code to match with newest Validators version and enforce Pandas <2 until new duckdb is released Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackary blackary blackary approved these changes

@sfc-gh-dmatthews sfc-gh-dmatthews sfc-gh-dmatthews approved these changes

@sfc-gh-zblackwood sfc-gh-zblackwood Awaiting requested review from sfc-gh-zblackwood

@sfc-gh-jcarroll sfc-gh-jcarroll Awaiting requested review from sfc-gh-jcarroll

Assignees

@sfc-gh-tszerszen sfc-gh-tszerszen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sfc-gh-tszerszen @sfc-gh-jcarroll @blackary @sfc-gh-zblackwood @sfc-gh-dmatthews