Linting #6
Merged
Linting #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tszerszen
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Overall LGTM and thank you for taking care of this @sfc-gh-zblackwood, this is an awesome work, test are present now and we have much clearer documentation ❤️
Please consider my comments and if you can please also wait for @sfc-gh-jcarroll and @sfc-gh-kbregula reviews for additional pair of eyes before merging 🙂
sfc-gh-jcarroll
approved these changes
Jul 29, 2023
Co-authored-by: Kamil Breguła <kamil.bregula@snowflake.com>
|
Accepted the workflow change, and added linters to test-reqs -- should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #2 to resolve some git fork weirdness :)