ignore Enter on composition for Japanese

streamlit · Jul 12, 2023 · 10e756d · 10e756d
1 parent 4ed2690
commit 10e756d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/frontend/lib/src/components/widgets/ChatInput/ChatInput.tsx b/frontend/lib/src/components/widgets/ChatInput/ChatInput.tsx
@@ -61,7 +61,7 @@ const isEnterKeyPressed = (
   // https://bugs.chromium.org/p/chromium/issues/detail?id=79407
 
   const { keyCode, key } = event
-  return key === "Enter" || keyCode === 13 || keyCode === 10
+  return (key === "Enter" || keyCode === 13 || keyCode === 10) && !event.nativeEvent.isComposing
 }
 
 function ChatInput({ width, element, widgetMgr }: Props): React.ReactElement {

diff --git a/frontend/lib/src/components/widgets/TextArea/TextArea.tsx b/frontend/lib/src/components/widgets/TextArea/TextArea.tsx
@@ -165,7 +165,7 @@ class TextArea extends React.PureComponent<Props, State> {
 
     // Using keyCode as well due to some different behaviors on Windows
     // https://bugs.chromium.org/p/chromium/issues/detail?id=79407
-    return key === "Enter" || keyCode === 13 || keyCode === 10
+    return (key === "Enter" || keyCode === 13 || keyCode === 10) && !event.nativeEvent.isComposing
   }
 
   private onKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>): void => {