Update selector

streamlit · May 6, 2024 · 2f34733 · 2f34733
1 parent c5eacf1
commit 2f34733
Show file tree

Hide file tree

Showing 72 changed files with 25 additions and 25 deletions.
diff --git a/.../linux/st_caption_test/st_caption-with_different_markdown_content[chromium].png b/.../linux/st_caption_test/st_caption-with_different_markdown_content[chromium].png
diff --git a/..._/linux/st_caption_test/st_caption-with_different_markdown_content[firefox].png b/..._/linux/st_caption_test/st_caption-with_different_markdown_content[firefox].png
diff --git a/...__/linux/st_caption_test/st_caption-with_different_markdown_content[webkit].png b/...__/linux/st_caption_test/st_caption-with_different_markdown_content[webkit].png
diff --git a/...x/st_heading_test/st_header-hover_with_help_and_anchor[dark_theme-chromium].png b/...x/st_heading_test/st_header-hover_with_help_and_anchor[dark_theme-chromium].png
diff --git a/...ux/st_heading_test/st_header-hover_with_help_and_anchor[dark_theme-firefox].png b/...ux/st_heading_test/st_header-hover_with_help_and_anchor[dark_theme-firefox].png
diff --git a/...nux/st_heading_test/st_header-hover_with_help_and_anchor[dark_theme-webkit].png b/...nux/st_heading_test/st_header-hover_with_help_and_anchor[dark_theme-webkit].png
diff --git a/.../st_heading_test/st_header-hover_with_help_and_anchor[light_theme-chromium].png b/.../st_heading_test/st_header-hover_with_help_and_anchor[light_theme-chromium].png
diff --git a/...x/st_heading_test/st_header-hover_with_help_and_anchor[light_theme-firefox].png b/...x/st_heading_test/st_header-hover_with_help_and_anchor[light_theme-firefox].png
diff --git a/...ux/st_heading_test/st_header-hover_with_help_and_anchor[light_theme-webkit].png b/...ux/st_heading_test/st_header-hover_with_help_and_anchor[light_theme-webkit].png
diff --git a/...ading_test/st_header-hover_with_help_and_hidden_anchor[dark_theme-chromium].png b/...ading_test/st_header-hover_with_help_and_hidden_anchor[dark_theme-chromium].png
diff --git a/...eading_test/st_header-hover_with_help_and_hidden_anchor[dark_theme-firefox].png b/...eading_test/st_header-hover_with_help_and_hidden_anchor[dark_theme-firefox].png
diff --git a/...heading_test/st_header-hover_with_help_and_hidden_anchor[dark_theme-webkit].png b/...heading_test/st_header-hover_with_help_and_hidden_anchor[dark_theme-webkit].png
diff --git a/...ding_test/st_header-hover_with_help_and_hidden_anchor[light_theme-chromium].png b/...ding_test/st_header-hover_with_help_and_hidden_anchor[light_theme-chromium].png
diff --git a/...ading_test/st_header-hover_with_help_and_hidden_anchor[light_theme-firefox].png b/...ading_test/st_header-hover_with_help_and_hidden_anchor[light_theme-firefox].png
diff --git a/...eading_test/st_header-hover_with_help_and_hidden_anchor[light_theme-webkit].png b/...eading_test/st_header-hover_with_help_and_hidden_anchor[light_theme-webkit].png
diff --git a/...ux/st_heading_test/st_header-hover_with_visible_anchor[dark_theme-chromium].png b/...ux/st_heading_test/st_header-hover_with_visible_anchor[dark_theme-chromium].png
diff --git a/...nux/st_heading_test/st_header-hover_with_visible_anchor[dark_theme-firefox].png b/...nux/st_heading_test/st_header-hover_with_visible_anchor[dark_theme-firefox].png
diff --git a/...inux/st_heading_test/st_header-hover_with_visible_anchor[dark_theme-webkit].png b/...inux/st_heading_test/st_header-hover_with_visible_anchor[dark_theme-webkit].png
diff --git a/...x/st_heading_test/st_header-hover_with_visible_anchor[light_theme-chromium].png b/...x/st_heading_test/st_header-hover_with_visible_anchor[light_theme-chromium].png
diff --git a/...ux/st_heading_test/st_header-hover_with_visible_anchor[light_theme-firefox].png b/...ux/st_heading_test/st_header-hover_with_visible_anchor[light_theme-firefox].png
diff --git a/...nux/st_heading_test/st_header-hover_with_visible_anchor[light_theme-webkit].png b/...nux/st_heading_test/st_header-hover_with_visible_anchor[light_theme-webkit].png
diff --git a/...hots__/linux/st_heading_test/st_header-title_with_link[dark_theme-chromium].png b/...hots__/linux/st_heading_test/st_header-title_with_link[dark_theme-chromium].png
diff --git a/...shots__/linux/st_heading_test/st_header-title_with_link[dark_theme-firefox].png b/...shots__/linux/st_heading_test/st_header-title_with_link[dark_theme-firefox].png
diff --git a/...pshots__/linux/st_heading_test/st_header-title_with_link[dark_theme-webkit].png b/...pshots__/linux/st_heading_test/st_header-title_with_link[dark_theme-webkit].png
diff --git a/...ots__/linux/st_heading_test/st_header-title_with_link[light_theme-chromium].png b/...ots__/linux/st_heading_test/st_header-title_with_link[light_theme-chromium].png
diff --git a/...hots__/linux/st_heading_test/st_header-title_with_link[light_theme-firefox].png b/...hots__/linux/st_heading_test/st_header-title_with_link[light_theme-firefox].png
diff --git a/...shots__/linux/st_heading_test/st_header-title_with_link[light_theme-webkit].png b/...shots__/linux/st_heading_test/st_header-title_with_link[light_theme-webkit].png
diff --git a/...__snapshots__/linux/st_heading_test/st_header-with_help[dark_theme-firefox].png b/...__snapshots__/linux/st_heading_test/st_header-with_help[dark_theme-firefox].png
diff --git a/.../__snapshots__/linux/st_heading_test/st_header-with_help[dark_theme-webkit].png b/.../__snapshots__/linux/st_heading_test/st_header-with_help[dark_theme-webkit].png
diff --git a/...snapshots__/linux/st_heading_test/st_header-with_help[light_theme-chromium].png b/...snapshots__/linux/st_heading_test/st_header-with_help[light_theme-chromium].png
diff --git a/..._snapshots__/linux/st_heading_test/st_header-with_help[light_theme-firefox].png b/..._snapshots__/linux/st_heading_test/st_header-with_help[light_theme-firefox].png
diff --git a/...__snapshots__/linux/st_heading_test/st_header-with_help[light_theme-webkit].png b/...__snapshots__/linux/st_heading_test/st_header-with_help[light_theme-webkit].png
diff --git a/...t_heading_test/st_subheader-hover_with_help_and_anchor[dark_theme-chromium].png b/...t_heading_test/st_subheader-hover_with_help_and_anchor[dark_theme-chromium].png
diff --git a/...st_heading_test/st_subheader-hover_with_help_and_anchor[dark_theme-firefox].png b/...st_heading_test/st_subheader-hover_with_help_and_anchor[dark_theme-firefox].png
diff --git a/.../st_heading_test/st_subheader-hover_with_help_and_anchor[dark_theme-webkit].png b/.../st_heading_test/st_subheader-hover_with_help_and_anchor[dark_theme-webkit].png
diff --git a/..._heading_test/st_subheader-hover_with_help_and_anchor[light_theme-chromium].png b/..._heading_test/st_subheader-hover_with_help_and_anchor[light_theme-chromium].png
diff --git a/...t_heading_test/st_subheader-hover_with_help_and_anchor[light_theme-firefox].png b/...t_heading_test/st_subheader-hover_with_help_and_anchor[light_theme-firefox].png
diff --git a/...st_heading_test/st_subheader-hover_with_help_and_anchor[light_theme-webkit].png b/...st_heading_test/st_subheader-hover_with_help_and_anchor[light_theme-webkit].png
diff --git a/...ng_test/st_subheader-hover_with_help_and_hidden_anchor[dark_theme-chromium].png b/...ng_test/st_subheader-hover_with_help_and_hidden_anchor[dark_theme-chromium].png
diff --git a/...ing_test/st_subheader-hover_with_help_and_hidden_anchor[dark_theme-firefox].png b/...ing_test/st_subheader-hover_with_help_and_hidden_anchor[dark_theme-firefox].png
diff --git a/...ding_test/st_subheader-hover_with_help_and_hidden_anchor[dark_theme-webkit].png b/...ding_test/st_subheader-hover_with_help_and_hidden_anchor[dark_theme-webkit].png
diff --git a/...g_test/st_subheader-hover_with_help_and_hidden_anchor[light_theme-chromium].png b/...g_test/st_subheader-hover_with_help_and_hidden_anchor[light_theme-chromium].png
diff --git a/...ng_test/st_subheader-hover_with_help_and_hidden_anchor[light_theme-firefox].png b/...ng_test/st_subheader-hover_with_help_and_hidden_anchor[light_theme-firefox].png
diff --git a/...ing_test/st_subheader-hover_with_help_and_hidden_anchor[light_theme-webkit].png b/...ing_test/st_subheader-hover_with_help_and_hidden_anchor[light_theme-webkit].png
diff --git a/...st_heading_test/st_subheader-hover_with_visible_anchor[dark_theme-chromium].png b/...st_heading_test/st_subheader-hover_with_visible_anchor[dark_theme-chromium].png
diff --git a/.../st_heading_test/st_subheader-hover_with_visible_anchor[dark_theme-firefox].png b/.../st_heading_test/st_subheader-hover_with_visible_anchor[dark_theme-firefox].png
diff --git a/...x/st_heading_test/st_subheader-hover_with_visible_anchor[dark_theme-webkit].png b/...x/st_heading_test/st_subheader-hover_with_visible_anchor[dark_theme-webkit].png
diff --git a/...t_heading_test/st_subheader-hover_with_visible_anchor[light_theme-chromium].png b/...t_heading_test/st_subheader-hover_with_visible_anchor[light_theme-chromium].png
diff --git a/...st_heading_test/st_subheader-hover_with_visible_anchor[light_theme-firefox].png b/...st_heading_test/st_subheader-hover_with_visible_anchor[light_theme-firefox].png
diff --git a/.../st_heading_test/st_subheader-hover_with_visible_anchor[light_theme-webkit].png b/.../st_heading_test/st_subheader-hover_with_visible_anchor[light_theme-webkit].png
diff --git a/.../linux/st_heading_test/st_subheader-with_code_and_help[dark_theme-chromium].png b/.../linux/st_heading_test/st_subheader-with_code_and_help[dark_theme-chromium].png
diff --git a/..._/linux/st_heading_test/st_subheader-with_code_and_help[dark_theme-firefox].png b/..._/linux/st_heading_test/st_subheader-with_code_and_help[dark_theme-firefox].png
diff --git a/...__/linux/st_heading_test/st_subheader-with_code_and_help[dark_theme-webkit].png b/...__/linux/st_heading_test/st_subheader-with_code_and_help[dark_theme-webkit].png
diff --git a/...linux/st_heading_test/st_subheader-with_code_and_help[light_theme-chromium].png b/...linux/st_heading_test/st_subheader-with_code_and_help[light_theme-chromium].png
diff --git a/.../linux/st_heading_test/st_subheader-with_code_and_help[light_theme-firefox].png b/.../linux/st_heading_test/st_subheader-with_code_and_help[light_theme-firefox].png
diff --git a/..._/linux/st_heading_test/st_subheader-with_code_and_help[light_theme-webkit].png b/..._/linux/st_heading_test/st_subheader-with_code_and_help[light_theme-webkit].png
diff --git a/...pshots__/linux/st_markdown_test/st_markdown-headers_beside_widget[chromium].png b/...pshots__/linux/st_markdown_test/st_markdown-headers_beside_widget[chromium].png
diff --git a/...napshots__/linux/st_markdown_test/st_markdown-headers_beside_widget[webkit].png b/...napshots__/linux/st_markdown_test/st_markdown-headers_beside_widget[webkit].png
diff --git a/...snapshots__/linux/st_markdown_test/st_markdown-headers_in_columns[chromium].png b/...snapshots__/linux/st_markdown_test/st_markdown-headers_in_columns[chromium].png
diff --git a/..._snapshots__/linux/st_markdown_test/st_markdown-headers_in_columns[firefox].png b/..._snapshots__/linux/st_markdown_test/st_markdown-headers_in_columns[firefox].png
diff --git a/...__snapshots__/linux/st_markdown_test/st_markdown-headers_in_columns[webkit].png b/...__snapshots__/linux/st_markdown_test/st_markdown-headers_in_columns[webkit].png
diff --git a/...s__/linux/st_markdown_test/st_markdown-headers_in_labeled_columns[chromium].png b/...s__/linux/st_markdown_test/st_markdown-headers_in_labeled_columns[chromium].png
diff --git a/...ts__/linux/st_markdown_test/st_markdown-headers_in_labeled_columns[firefox].png b/...ts__/linux/st_markdown_test/st_markdown-headers_in_labeled_columns[firefox].png
diff --git a/...ots__/linux/st_markdown_test/st_markdown-headers_in_labeled_columns[webkit].png b/...ots__/linux/st_markdown_test/st_markdown-headers_in_labeled_columns[webkit].png
diff --git a/...inux/st_markdown_test/st_markdown-headers_joined_in_single_command[firefox].png b/...inux/st_markdown_test/st_markdown-headers_joined_in_single_command[firefox].png
diff --git a/...linux/st_markdown_test/st_markdown-headers_joined_in_single_command[webkit].png b/...linux/st_markdown_test/st_markdown-headers_joined_in_single_command[webkit].png
diff --git a/.../linux/st_markdown_test/st_markdown-headers_via_multiple_commands[chromium].png b/.../linux/st_markdown_test/st_markdown-headers_via_multiple_commands[chromium].png
diff --git a/..._/linux/st_markdown_test/st_markdown-headers_via_multiple_commands[firefox].png b/..._/linux/st_markdown_test/st_markdown-headers_via_multiple_commands[firefox].png
diff --git a/...__/linux/st_markdown_test/st_markdown-headers_via_multiple_commands[webkit].png b/...__/linux/st_markdown_test/st_markdown-headers_via_multiple_commands[webkit].png
diff --git a/e2e_playwright/st_heading_test.py b/e2e_playwright/st_heading_test.py
@@ -144,22 +144,23 @@ def test_headers_hovered_snapshot_match(
 ):
     headers = _get_header_elements(themed_app)
     header = headers.nth(0)
+    link_container = header.get_by_test_id("stHeaderActionElements").locator("a")
+    expect(link_container).to_have_css("visibility", "hidden")
     header.hover()
-    link_container = header.get_by_test_id("StyledLinkIconContainer")
-    expect(link_container).to_have_css("opacity", "1")
-    assert_snapshot(link_container, name="st_header-hover_with_visible_anchor")
+    expect(link_container).to_have_css("visibility", "visible")
+    assert_snapshot(header, name="st_header-hover_with_visible_anchor")
 
     header = headers.nth(3)
+    link_container = header.get_by_test_id("stHeaderActionElements").locator("a")
+    expect(link_container).to_have_css("visibility", "hidden")
     header.hover()
-    link_container = header.get_by_test_id("StyledLinkIconContainer")
-    expect(link_container).to_have_css("opacity", "1")
-    assert_snapshot(link_container, name="st_header-hover_with_help_and_anchor")
+    expect(link_container).to_have_css("visibility", "visible")
+    assert_snapshot(header, name="st_header-hover_with_help_and_anchor")
 
     header = headers.nth(4)
-    header.hover()
-    link_container = header.get_by_test_id("StyledLinkIconContainer")
-    expect(link_container).to_have_css("opacity", "1")
-    assert_snapshot(link_container, name="st_header-hover_with_help_and_hidden_anchor")
+    link_container = header.get_by_test_id("stHeaderActionElements").locator("a")
+    expect(link_container).not_to_be_attached()
+    assert_snapshot(header, name="st_header-hover_with_help_and_hidden_anchor")
 
 
 def test_subheaders_snapshot_match(
@@ -176,24 +177,23 @@ def test_subheaders_hovered_snapshot_match(
 ):
     headers = _get_subheader_elements(themed_app)
     header = headers.nth(0)
+    link_container = header.get_by_test_id("stHeaderActionElements").locator("a")
+    expect(link_container).to_have_css("visibility", "hidden")
     header.hover()
-    link_container = header.get_by_test_id("StyledLinkIconContainer")
-    expect(link_container).to_have_css("opacity", "1")
-    assert_snapshot(link_container, name="st_subheader-hover_with_visible_anchor")
+    expect(link_container).to_have_css("visibility", "visible")
+    assert_snapshot(header, name="st_subheader-hover_with_visible_anchor")
 
     header = headers.nth(5)
+    link_container = header.get_by_test_id("stHeaderActionElements").locator("a")
+    expect(link_container).to_have_css("visibility", "hidden")
     header.hover()
-    link_container = header.get_by_test_id("StyledLinkIconContainer")
-    expect(link_container).to_have_css("opacity", "1")
-    assert_snapshot(link_container, name="st_subheader-hover_with_help_and_anchor")
+    expect(link_container).to_have_css("visibility", "visible")
+    assert_snapshot(header, name="st_subheader-hover_with_help_and_anchor")
 
     header = headers.nth(6)
-    header.hover()
-    link_container = header.get_by_test_id("StyledLinkIconContainer")
-    expect(link_container).to_have_css("opacity", "1")
-    assert_snapshot(
-        link_container, name="st_subheader-hover_with_help_and_hidden_anchor"
-    )
+    link_container = header.get_by_test_id("stHeaderActionElements").locator("a")
+    expect(link_container).not_to_be_attached()
+    assert_snapshot(header, name="st_subheader-hover_with_help_and_hidden_anchor")
 
 
 def test_links_are_rendered_correctly_snapshot(

diff --git a/frontend/lib/src/components/shared/StreamlitMarkdown/StreamlitMarkdown.test.tsx b/frontend/lib/src/components/shared/StreamlitMarkdown/StreamlitMarkdown.test.tsx
@@ -151,7 +151,7 @@ describe("StreamlitMarkdown", () => {
       </IsSidebarContext.Provider>
     )
     expect(
-      screen.queryByTestId("stStyledHeadingWithActionElements=1")
+      screen.queryByTestId("stStyledHeadingWithActionElements")
     ).not.toBeInTheDocument()
   })
 

diff --git a/frontend/lib/src/components/shared/StreamlitMarkdown/styled-components.ts b/frontend/lib/src/components/shared/StreamlitMarkdown/styled-components.ts
@@ -149,11 +149,11 @@ export const StyledHeadingWithActionElements = styled.div(({ theme }) => ({
   // we use opacity instead of visibility because the react-testing-library seems
   // to have issues with queryByRole('link') otherwise, even when triggering hover-events
   "& .stHeaderActionElements > a": {
-    opacity: 0,
+    visibility: "hidden",
   },
   ":hover": {
     "& .stHeaderActionElements > a": {
-      opacity: 1,
+      visibility: "visible",
     },
   },
 }))