-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor vega-related charting (#8595)
## Describe your changes This PR refactors/restructures our backend logic that handles all vega-related charting: `st.vega_lite_chart`, `st.altair_chart`, `st.line_chart`, `st.area_chart`, `st.bar_chart`, `st.scatter_chart`. - The built-in charting logic is migrated to `built_in_chart_utils` - All commands are migrated to `vega_charts` and refactored to reuse more shared logic. - This also applies some refactoring to how we handle adding `add_rows` metadata by just relaying on the available metadata instead of checking for the delta type. ## Testing Plan - Updated unit tests - No big logical changes. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
- Loading branch information
1 parent
d93a282
commit 67d0b04
Showing
8 changed files
with
1,483 additions
and
1,463 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.