Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ImmutableJS (scoping!) #18

Closed
kantuni opened this issue Aug 26, 2019 · 3 comments
Closed

Remove ImmutableJS (scoping!) #18

kantuni opened this issue Aug 26, 2019 · 3 comments
Assignees
@tconkling
Labels
area:infra

Comments

@kantuni
Copy link
Collaborator

kantuni commented Aug 26, 2019

No description provided.

@kantuni kantuni added the type:enhancement Requests for feature enhancements or new features label Aug 26, 2019
@kantuni kantuni self-assigned this Aug 26, 2019
@arraydude arraydude added area:infra and removed type:enhancement Requests for feature enhancements or new features labels Apr 27, 2020
@kantuni kantuni removed their assignment May 11, 2020
@tconkling tconkling self-assigned this Sep 14, 2020
@tconkling
Copy link
Contributor

tconkling commented Sep 14, 2020 •
edited

Structure

  • Delta messages come into DeltaParser.ts, which converts them to immutables
  • Elements represent new report elements
  • Block.tsx transforms Element deltas into React elements
  • Periodically (on a timer), App.tsx rebuilds the entire app layout by iterating the list of all elements, and creating the proper React component for each one.

Plan

  • Take a piecemeal approach to this. This means preserving the ImmutableJS format for each element until it's converted.
  • Ideally, this means not using ImmutableJS in Elements, BlockElement, and ReportElement, and instead doing the conversion on an ad-hoc basis?
  • Meaning that ReportElement should be an ElementProto + reportID

@exalate-issue-sync
Copy link

Tim Conkling commented: I’m making design and implementation notes in a Notion page: [https://www.notion.so/streamlit/immutablejs-Refactor-c8bf2575c0c240bd913d263bb7ba2866|https://www.notion.so/streamlit/immutablejs-Refactor-c8bf2575c0c240bd913d263bb7ba2866]

@exalate-issue-sync exalate-issue-sync bot changed the title Remove ImmutableJS (as much as possible) Remove ImmutableJS (scoping!) Sep 28, 2020
@akrolsmir
Copy link
Contributor

Fixed by Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tconkling tconkling

Labels
area:infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arraydude @tconkling @akrolsmir @kantuni