New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
st.dataframe is creating a pair of invisible quotes since 1.23.0 for data entries with commas in the text #7032
Comments
Thanks for sharing this, @anirudhkaushik008! I was able to reproduce this with Excel and Streamlit version 1.25.0 – |
Yes, now to see if someone can figure out where the bug is coming from. There is no reason this should exist |
The issue itself comes from the underlying datagrid library. But it might be fixed soon. |
From what I've seen, a new stable version of glide-data-grid that resolves the bug has been released. |
## Describe your changes Glide-data-grid had a [major update](glideapps/glide-data-grid#810). This PR updates to this version and adapts the implementation for all the breaking/updated features. This update fixes a variety of issues (see list below). ## GitHub Issue Link (if applicable) Closes #6900 Closes #7032 Closes #7727 Closes #6810 Closes #7930 Closes #7949 Closes #7831 Closes #8168 ## Testing Plan - Updated tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
We merged the update of the underlying grid library. I believe this fixes the issue described here. This will be released in |
Just wanted to follow up that the updates are live as of the latest release 1.32.2. 🥳 Thanks everyone for your valuable input and feedback! |
## Describe your changes Glide-data-grid had a [major update](glideapps/glide-data-grid#810). This PR updates to this version and adapts the implementation for all the breaking/updated features. This update fixes a variety of issues (see list below). ## GitHub Issue Link (if applicable) Closes streamlit#6900 Closes streamlit#7032 Closes streamlit#7727 Closes streamlit#6810 Closes streamlit#7930 Closes streamlit#7949 Closes streamlit#7831 Closes streamlit#8168 ## Testing Plan - Updated tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Checklist
Summary
I did not have this problem with streamlit 1.22.0
When you have a dataframe that has a column with strings and has a commas within the string, the dataframe is created and displayed normally. However when you select the dataframe and copy it over to say, excel, the entries that had a comma within the string appears with quotes around them. And it is only for those strings that have a comma in them.
This started with whatever amount of sweeping updates that happened with st.dataframe or st.data_editor in 1.23.0. I tried downgrading to 1.22.0 and the issue resolved itself
Reproducible Code Example
Steps To Reproduce
Expected Behavior
With an older version, the dataframe is printed as it should be
Current Behavior
The entry asdf,jklh has a comma in the string and therefore appears as "asdf,jklh" when copying it to any text editor or spreadsheet
Is this a regression?
Debug info
Additional Information
No response
The text was updated successfully, but these errors were encountered: