Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geo layers to DeckGlJsonChart #1306

Merged
merged 16 commits into from
May 6, 2020
Merged

Add geo layers to DeckGlJsonChart #1306

merged 16 commits into from
May 6, 2020

Conversation

kantuni
Copy link
Collaborator

@kantuni kantuni commented Apr 5, 2020 •
edited by jrhone
Loading

Closes #1229

@kantuni kantuni requested a review from a team April 5, 2020 18:00
@kantuni kantuni mentioned this pull request Apr 5, 2020
Closed
@kantuni kantuni changed the title Add geo layers to DeckGlJson Add geo layers to DeckGlJsonChart Apr 5, 2020
@kantuni kantuni requested a review from arraydude April 5, 2020 19:35
jrhone
jrhone reviewed Apr 5, 2020
View reviewed changes
Copy link
Contributor

@jrhone jrhone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests?

@kantuni
Copy link
Collaborator Author

kantuni commented Apr 6, 2020 •
edited
Loading

Needs tests?

@jrhone Maybe E2E? Thoughts?

@jrhone
Copy link
Contributor

jrhone commented Apr 10, 2020

Maybe E2E? Thoughts?

Whatever allows us to verify that Geolayer maps render correctly :)

@jrhone
Copy link
Contributor

jrhone commented Apr 14, 2020

Need to add the snapshot.png

@kantuni
Copy link
Collaborator Author

kantuni commented Apr 14, 2020

Need to add the snapshot.png

@jrhone How do we do this?

@andfanilo andfanilo mentioned this pull request Apr 22, 2020
Closed
@jrhone
Copy link
Contributor

jrhone commented Apr 22, 2020

Docker-compose mounts a local volume to the container so you should see the snapshots appear on the host after running the tests in the container. Then git-add and commit from the host.

@kantuni kantuni requested a review from randyzwitch as a code owner May 6, 2020 12:49
randyzwitch
randyzwitch reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@randyzwitch randyzwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these actual doc changes, or a prior commit?

@kantuni
Copy link
Collaborator Author

kantuni commented May 6, 2020

Are these actual doc changes, or a prior commit?

I just pulled them from develop.

@randyzwitch
Copy link
Contributor

Thanks @kantuni. These changes are in @jrhone 's PRs as well, which makes it tough to understand if people are changing things vs. syncing their branches. Maybe another artifact of the issue @tvst brought up in stand up yesterday

@jrhone
Copy link
Contributor

jrhone commented May 6, 2020

Is it prettier/black making some modifications?

Shouldn't be appearing if we're just merging from and back into develop.

@kantuni
Copy link
Collaborator Author

kantuni commented May 6, 2020

Is it prettier/black making some modifications?

Shouldn't be appearing if we're just merging from and back into develop.

Formatters are running on every commit.

@kantuni kantuni merged commit 237359f into streamlit:develop May 6, 2020
@kantuni kantuni deleted the feature/geo-layers branch May 6, 2020 20:26
tconkling added a commit that referenced this pull request May 11, 2020
@tconkling
Merge branch 'develop' into feature/plugins
aff24d5 
* develop:
  Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (#1407)
  Fixing date_input | min and max selectable date issues (#1426)
  Torch Tensorbase hash func (#1394)
  Change list() cast (#1401)
  Add geo layers to DeckGlJsonChart (#1306)
  Clean up use of LoDash (#1404)
  Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (#1403)
  Release 0.59.0 (#1405)
  Setting textarea height and unit tests (#1411)
tconkling added a commit to tconkling/streamlit that referenced this pull request May 11, 2020
@tconkling
Merge branch 'feature/plugins' into tim/declare_component
953a14b 
* feature/plugins:
  black reformatting
  Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (streamlit#1407)
  Fixing date_input | min and max selectable date issues (streamlit#1426)
  Torch Tensorbase hash func (streamlit#1394)
  Change list() cast (streamlit#1401)
  Component template tweaks
  Components: alpha 2 cleanup (streamlit#1425)
  Fix dataframe support
  Add geo layers to DeckGlJsonChart (streamlit#1306)
  Clean up use of LoDash (streamlit#1404)
  Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (streamlit#1403)
  Release 0.59.0 (streamlit#1405)
  Setting textarea height and unit tests (streamlit#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyzwitch randyzwitch randyzwitch left review comments

@jrhone jrhone jrhone approved these changes

@arraydude arraydude Awaiting requested review from arraydude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H3HexagonLayer in pydeck doesn't display
3 participants
@kantuni @jrhone @randyzwitch