Batch updates to report elements in the App state #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvst
approved these changes
Sep 26, 2019
This was referenced Sep 28, 2019
Closed
jrhone
changed the title
|
I merged this into develop on my machine and then found a bug. Try this:
Expected: the |
tvst
suggested changes
Oct 3, 2019
There was a problem hiding this comment.
Ok, so I think your first solution was the cleanest after all 😁
We just need to tweak some of the names for clarity. Here's what I came up with:
tvst@43be303
tvst
approved these changes
Oct 4, 2019
| @@ -50,6 +50,8 @@ import "assets/css/theme.scss" | |||
| import "./App.scss" | |||
| import "assets/css/header.scss" | |||
|
|
|||
| const ELEMENT_LIST_BUFFER_TIMEOUT_MS = 10 | |||
There was a problem hiding this comment.
Add comment explaining what this is. Something like: "We update the elements list in the state in batches. This is how often we apply those batches."
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Oct 7, 2019
* develop: Support cli parameters (streamlit#186) Update README.md Update README.md (streamlit#282) Bug fix: make Streamlit watch files in subfolders again (streamlit#265) fix st.code("") (streamlit#272) different jslint commands for circleci and not (streamlit#273) Batch updates to report elements in the App state (streamlit#194) Minor typo in pull_request_template.md (streamlit#262) Fix wrong quote used in the provided sample code (streamlit#267) Fix websocket port handling (streamlit#263) Closing sidebar when clicking outside (streamlit#223) Version 0.47.2 (streamlit#212) [docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235) Update README.md Remove checkbox from CLA in PR Template Update README.md Update README.md mapping_demo: catch urllib errors (streamlit#224)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Oct 8, 2019
* develop:
Read config from ${CWD}/.streamlit/config.toml (streamlit#227)
Fix unsafe_allow_html (streamlit#259)
Support cli parameters (streamlit#186)
Update README.md
Update README.md (streamlit#282)
Bug fix: make Streamlit watch files in subfolders again (streamlit#265)
fix st.code("") (streamlit#272)
different jslint commands for circleci and not (streamlit#273)
Batch updates to report elements in the App state (streamlit#194)
Minor typo in pull_request_template.md (streamlit#262)
Fix wrong quote used in the provided sample code (streamlit#267)
Fix websocket port handling (streamlit#263)
Closing sidebar when clicking outside (streamlit#223)
Version 0.47.2 (streamlit#212)
[docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235)
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch every 10 ms of updates to
elementsin the App state.