Add global GTM container #2128
Merged
Add global GTM container #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrolsmir
approved these changes
Oct 8, 2020
| @@ -25,6 +25,17 @@ | |||
| })(window, document, 'script', 'dataLayer', 'GTM-TXFLBCM');</script> | |||
| <!-- End Google Tag Manager --> | |||
|
|
|||
| <!-- Google Tag Manager --> | |||
There was a problem hiding this comment.
Can we add a comment in-line here, to explain why we're doing two GTMs?
(It seems a little weird to duplicate the exact code instead of just passing in the GTM id ('GTM-52GRQSL') into a reusable function, but on reflection this is really short anyways and is an official copy+paste So I think we should keep as-is)
There was a problem hiding this comment.
this is literally here for a week, possibly less. does it really need commentary?
There was a problem hiding this comment.
Ah, I thought this was going to be around longer than that. NVM then!
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Oct 12, 2020
# By karrie (7) and others # Via GitHub * develop: Removing cache option from main menu if s4a (streamlit#2149) Fix empty deploy page (streamlit#2148) Don't wait for unit tests before starting Cypress (streamlit#2142) Fix formatting of st.file_uploader docstring (streamlit#2141) Fix broken link in 0.68 changelog (streamlit#2144) Fix useEffect warning (streamlit#2137) Add global GTM container (streamlit#2128) Allow Streamlit server to handle Range Requests (streamlit#1967) rename hosted to hostedAt (streamlit#2132) Update change log Update notices Up version to 0.68.0 Rename hosted to hostedAt in tracking data (streamlit#2132) Inject tracking data (streamlit#2110) [Feature Branch] File uploader (streamlit#2130) links for docs (streamlit#2129) Upgrade ProtobufJS and fix build script (streamlit#2118) Refresh landing page (streamlit#2116) Improve docstrings + tutorials for Layout (streamlit#2117) Better 'streamlit run' error message when no extension provided (streamlit#2115) # Conflicts: # frontend/src/components/elements/Video/Video.tsx # frontend/src/components/widgets/FileUploader/FileUploader.test.tsx # frontend/src/components/widgets/FileUploader/FileUploader.tsx # frontend/src/lib/utils.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the analytics implementation work, adding a second GTM container for development purposes. This will allow implementors to create rules separate from current tracking. When cut-over ready to happen, can submit another PR to remove the original GTM container