Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a File Uploader Widget #488
Add a File Uploader Widget #488
Changes from 16 commits
2c84231
247ed6d
6caacc1
da46d7a
eb8f340
0b4c8eb
4f69872
62345ad
6a20616
f0fc5bb
48f11e1
ee7dca5
1445872
a284eae
0ac4202
5283546
e0c31c0
ffb93eb
e4b60b4
0434c54
f91b18a
0da9d5e
1975c8d
5fd8c85
b4a71e7
20c2763
92b35a3
cfad578
4ed4f8c
cbc4d61
56b1063
718b190
0558c7a
96cb276
09983d8
5fac828
14c005b
2959ee0
ef01b9d
d0546a5
cd5f59d
7ea7aaf
3053061
ac11e4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all these
-webkit
properties needed? It's best to avoid browser-specific code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
className
should beWidget stFileUploader
.Without
Widget
, the<label>
doesn't look right.And all Streamlit elements need to be wrapped in a DOM element with class
stElementName
(see our style guide)