add types to net_util.py #4916
Merged
add types to net_util.py #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
approved these changes
Jul 1, 2022
| @@ -92,17 +90,17 @@ def get_internal_ip(): | |||
| return _internal_ip | |||
|
|
|||
|
|
|||
| def _make_blocking_http_get(url, timeout=5): | |||
| def _make_blocking_http_get(url: str, timeout: float = 5) -> Optional[str]: | |||
There was a problem hiding this comment.
nit: not particularly important, but should this be written as 5.0 instead of 5 to emphasize that it's a float?
There was a problem hiding this comment.
I don't hold this opinion strongly, but I think no. The type annotation is already there to tell you the type -- the reason to use a decimal in C-like languages is to prevent coercion-to-int in statements that would result in the loss of the decimal value, but I think that's not an issue in Python. (Like, 1/3 in Python results in a float even though both values are ints.)
There was a problem hiding this comment.
(That said, there may very well be some best practice I'm not aware of in which case my answer would change to "yes definitely!")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by type annotations before re-namespacing