New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPA sidebar adjustments #5445
MPA sidebar adjustments #5445
Conversation
Hm, looks like a conflict with a different change to |
@vdonato Fixed! Thanks for the thorough review 馃挴 |
馃摎 Context
This PR addresses a couple of design tweaks within the MPA sidebar, adjusting how pages without icons look, and truncating long page names.
What kind of change does this PR introduce?
馃 Description of Changes
Removed default icon when no emoji is present in
Sidebar/SidebarNav.tsx
;Update style for MPA pages in
Sidebar/styled-components.ts
;Use
<OverflowTooltip />
inSidebar/SidebarNav.tsx
to truncate long page names;Update unit and e2e test
Revised:
Current:
馃И Testing Done
馃寪 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.