Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPA sidebar adjustments #5445

Merged
merged 10 commits into from Oct 5, 2022
Merged

MPA sidebar adjustments #5445

merged 10 commits into from Oct 5, 2022

Conversation

imjuangarcia
Copy link

@imjuangarcia imjuangarcia commented Sep 29, 2022

馃摎 Context

This PR addresses a couple of design tweaks within the MPA sidebar, adjusting how pages without icons look, and truncating long page names.

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe: Design change

馃 Description of Changes

  • Removed default icon when no emoji is present in Sidebar/SidebarNav.tsx;

  • Update style for MPA pages in Sidebar/styled-components.ts;

  • Use <OverflowTooltip /> in Sidebar/SidebarNav.tsx to truncate long page names;

  • Update unit and e2e test

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

Screen Shot 2022-09-29 at 10 54 21 AM

Screen Shot 2022-09-29 at 10 53 10 AM

Screen Shot 2022-09-29 at 10 53 05 AM

Screen Shot 2022-09-29 at 10 25 33 AM

Screen Shot 2022-09-29 at 10 25 41 AM

Screen Shot 2022-09-29 at 10 04 17 AM

Screen Shot 2022-09-29 at 10 12 09 AM

Current:

Untitled

Screen Shot 2022-09-29 at 1 22 29 PM

Screen Shot 2022-09-29 at 9 49 52 AM

馃И Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

馃寪 References


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@imjuangarcia imjuangarcia marked this pull request as ready for review September 29, 2022 16:34
@imjuangarcia imjuangarcia requested a review from a team September 29, 2022 16:34
@vdonato
Copy link
Collaborator

vdonato commented Oct 5, 2022

Hm, looks like a conflict with a different change to SidebarNav.test.tsx appeared. Not sure which PR could have caused this, so I must have missed it. This should be good to go once that's resolved!

@imjuangarcia
Copy link
Author

Hm, looks like a conflict with a different change to SidebarNav.test.tsx appeared. Not sure which PR could have caused this, so I must have missed it. This should be good to go once that's resolved!

@vdonato Fixed! Thanks for the thorough review 馃挴

@vdonato vdonato merged commit ccc70f0 into develop Oct 5, 2022
@vdonato vdonato deleted the sidebar-adjustments branch October 5, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants