Fix: Remove flaky date input calendar snapshot test #6769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kmcgrady
approved these changes
Jun 1, 2023
tconkling
pushed a commit
to tconkling/streamlit
that referenced
this pull request
Jun 1, 2023
* Fix flaky date input snapshot test * Fix trigger error edge case
sfc-gh-tconkling
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Fix: Remove flaky date input calendar snapshot test (#6769) * Fix flaky date input snapshot test * Fix trigger error edge case * Fix typo in data_editor docstring and deprecation msg: `edited_rows` -> `edited_cells` (#6770) * Fix typo in data_editor warning: `edited_rows` -> `edited_cells` * Fix same typo in deprecation warning --------- Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com> * Up version to 1.23.0 --------- Co-authored-by: Maya Barnes <63436329+mayagbarnes@users.noreply.github.com> Co-authored-by: Snehan Kekre <snehan.minerva@gmail.com> Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com>
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jun 6, 2023
* develop: Remove tensorflow and pytorch from test requirements (streamlit#6807) Fix readme links (streamlit#6800) Update PR template to be simpler and more approachable (streamlit#6679) README updated with links to docs (streamlit#6780) Refactor: withHostCommunication -> HostCommunicationManager (streamlit#6746) Add python 3.11 to classifiers list. (streamlit#6786) Release/1.23.1 (streamlit#6777) We depend on typing-extensions 4.0.1 (streamlit#6776) Release/1.23.0 (streamlit#6773) Fix typo in data_editor docstring and deprecation msg: `edited_rows` -> `edited_cells` (streamlit#6770) Fix: Remove flaky date input calendar snapshot test (streamlit#6769) Fix 3218, patch pydantic in_ipython function (streamlit#6664) Upgrade react-range to fix memory usage of sliders (streamlit#6764) Make st.write pretty-print dataclasses using st.help (streamlit#6750) Replace curly with straightquotes in docstring examples (streamlit#6757)
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
* Fix flaky date input snapshot test * Fix trigger error edge case
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
* Fix: Remove flaky date input calendar snapshot test (streamlit#6769) * Fix flaky date input snapshot test * Fix trigger error edge case * Fix typo in data_editor docstring and deprecation msg: `edited_rows` -> `edited_cells` (streamlit#6770) * Fix typo in data_editor warning: `edited_rows` -> `edited_cells` * Fix same typo in deprecation warning --------- Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com> * Up version to 1.23.0 --------- Co-authored-by: Maya Barnes <63436329+mayagbarnes@users.noreply.github.com> Co-authored-by: Snehan Kekre <snehan.minerva@gmail.com> Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com>
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
* Fix flaky date input snapshot test * Fix trigger error edge case
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
* Fix: Remove flaky date input calendar snapshot test (streamlit#6769) * Fix flaky date input snapshot test * Fix trigger error edge case * Fix typo in data_editor docstring and deprecation msg: `edited_rows` -> `edited_cells` (streamlit#6770) * Fix typo in data_editor warning: `edited_rows` -> `edited_cells` * Fix same typo in deprecation warning --------- Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com> * Up version to 1.23.0 --------- Co-authored-by: Maya Barnes <63436329+mayagbarnes@users.noreply.github.com> Co-authored-by: Snehan Kekre <snehan.minerva@gmail.com> Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com>
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Fix flaky date input snapshot test * Fix trigger error edge case
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Fix: Remove flaky date input calendar snapshot test (streamlit#6769) * Fix flaky date input snapshot test * Fix trigger error edge case * Fix typo in data_editor docstring and deprecation msg: `edited_rows` -> `edited_cells` (streamlit#6770) * Fix typo in data_editor warning: `edited_rows` -> `edited_cells` * Fix same typo in deprecation warning --------- Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com> * Up version to 1.23.0 --------- Co-authored-by: Maya Barnes <63436329+mayagbarnes@users.noreply.github.com> Co-authored-by: Snehan Kekre <snehan.minerva@gmail.com> Co-authored-by: Ken McGrady <ken.mcgrady@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Context
Flaky/Blocking test fix -
st.date_input- renders the calendar component correctlyRemoves the snapshot test for the empty date range
st.date_inputcalendar (which always shows the current month/year) as it will break at least monthly - see below. We have 7 additionalst.date_inputcalendar snapshot tests that cover both dark & light theme, so I don't think its removal impacts coverage.Also added additional safeguard against GH Actions CI edge case where multiple calendars periodically passed to
.matchImageSnapshotcausing a.triggererror message (see error run here for example)