add datetime hashing for st.cache_data and st.cache_resource #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
…it#6812) Previously hashing of datetime objects happens via calling __reduce__, but that fails when datetime object was aware (containing information about the timezone). This changes adding special hashing handling for DateTime objects, by converting them to isoformat(which contains information about timezone offset). Please note that via that we lose information about the exact time zone in hashing, but information about UTC offset will be preserved. So e.g. same date-times with different timezones, but the same time stamp and offset will be hashed to the same value. Which should be fine in the vast majority of cases.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
…it#6812) Previously hashing of datetime objects happens via calling __reduce__, but that fails when datetime object was aware (containing information about the timezone). This changes adding special hashing handling for DateTime objects, by converting them to isoformat(which contains information about timezone offset). Please note that via that we lose information about the exact time zone in hashing, but information about UTC offset will be preserved. So e.g. same date-times with different timezones, but the same time stamp and offset will be hashed to the same value. Which should be fine in the vast majority of cases.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…it#6812) Previously hashing of datetime objects happens via calling __reduce__, but that fails when datetime object was aware (containing information about the timezone). This changes adding special hashing handling for DateTime objects, by converting them to isoformat(which contains information about timezone offset). Please note that via that we lose information about the exact time zone in hashing, but information about UTC offset will be preserved. So e.g. same date-times with different timezones, but the same time stamp and offset will be hashed to the same value. Which should be fine in the vast majority of cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Previously hashing of
datetimeobjects happens via calling__reduce__, but that fails when datetime object was aware (containing information about the timezone).This changes adding special hashing handling for DateTime objects, by converting them to
isoformat(which contains information about timezone offset).Please note that via that we lose information about the exact time zone in hashing, but information about UTC offset will be preserved. So e.g. same date-times with different timezones, but the same time stamp and offset will be hashed to the same value. Which should be fine in the vast majority of cases.
GitHub Issue Link #5110 , #6690
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.