Start work on fixing file uploader and camera input e2e tests #6891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
changed the title
vdonato
changed the title
kajarenc
approved these changes
Jun 28, 2023
vdonato
merged commit 6ef2347
into
feature/file_uploader_abstractions
45 of 54 checks passed
vdonato
added a commit
that referenced
this pull request
Jun 28, 2023
* Run autoformatter on e2e/specs/st_file_uploader.spec.js * Fix some more small type errors * Fix watched cypress route in st_file_uploader.spec.js
vdonato
added a commit
that referenced
this pull request
Jul 11, 2023
* Run autoformatter on e2e/specs/st_file_uploader.spec.js * Fix some more small type errors * Fix watched cypress route in st_file_uploader.spec.js
kajarenc
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Run autoformatter on e2e/specs/st_file_uploader.spec.js * Fix some more small type errors * Fix watched cypress route in st_file_uploader.spec.js
vdonato
added a commit
that referenced
this pull request
Jul 18, 2023
* Run autoformatter on e2e/specs/st_file_uploader.spec.js * Fix some more small type errors * Fix watched cypress route in st_file_uploader.spec.js
kajarenc
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Run autoformatter on e2e/specs/st_file_uploader.spec.js * Fix some more small type errors * Fix watched cypress route in st_file_uploader.spec.js
kajarenc
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Run autoformatter on e2e/specs/st_file_uploader.spec.js * Fix some more small type errors * Fix watched cypress route in st_file_uploader.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It's easiest to review the commits in this PR individually.
This PR fixes most issues with file uploader and camera input e2e tests. Somewhat strangley,
the last failing e2e test seems to be doing what we expect to from the video artifact, but cypress
still errors out.