Fix issue with file uploader dropping every other file #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajarenc
approved these changes
Jun 28, 2023
vdonato
force-pushed
the
vdonato/file_uploader_bugfix
branch
from
72eb7b0
to
103808f
Compare
vdonato
merged commit 65f33c1
into
feature/file_uploader_abstractions
34 of 39 checks passed
vdonato
added a commit
that referenced
this pull request
Jun 28, 2023
vdonato
added a commit
that referenced
this pull request
Jul 11, 2023
kajarenc
pushed a commit
that referenced
this pull request
Jul 13, 2023
vdonato
added a commit
that referenced
this pull request
Jul 18, 2023
kajarenc
pushed a commit
that referenced
this pull request
Jul 24, 2023
kajarenc
pushed a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug in the file uploader feature branch where uploading a second
file to a file uploader accepting a single file (without clearing the first one) doesn't work
correctly.
The root cause of this issue is that the original file is removed from the FileUploader react
component's state before we've fetched new file URLs and started the file upload process.
This causes react to call the component's
componentDidUpdatemethod too early, whichtriggers a script rerun with an empty file uploader state.
The fix is to defer any state mutations until after we've fetched fileUrls + started uploading files.