Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hamburger menu icon to overflow #6947

Merged
merged 12 commits into from Jul 7, 2023
Merged

Conversation

sfc-gh-jgarcia
Copy link
Contributor

@sfc-gh-jgarcia sfc-gh-jgarcia commented Jul 4, 2023

Describe your changes

This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.

Notion links

Testing Plan

  • Explanation of why no additional tests are needed: All tests are already in place
  • Unit Tests (JS and/or Python): Updated
  • E2E Tests: Updated
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-jgarcia sfc-gh-jgarcia marked this pull request as ready for review July 5, 2023 19:18
@mayagbarnes mayagbarnes changed the title WIP: Update overflow menu icon Update hamburger menu icon to overflow Jul 6, 2023
Copy link
Collaborator

@mayagbarnes mayagbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄
Nit: Could you do a pass across the codebase to remove any reference to the "hamburger" menu and substitute it with main menu? Think this will avoid future confusion.

@sfc-gh-jgarcia
Copy link
Contributor Author

Could you do a pass across the codebase to remove any reference to the "hamburger" menu and substitute it with main menu?

@mayagbarnes Sure can do! Updated on b1c5da2

@mayagbarnes mayagbarnes merged commit 7fc8f34 into develop Jul 7, 2023
48 checks passed
@mayagbarnes mayagbarnes deleted the update-hamburger-menu branch July 7, 2023 02:27
tconkling added a commit to tconkling/streamlit that referenced this pull request Jul 10, 2023
* develop:
  Respect current existing env var in build_info.py (streamlit#6906)
  fix: frontend/package.json & frontend/yarn.lock to reduce vulnerabilities (streamlit#6959)
  Update hamburger menu icon to overflow (streamlit#6947)
  Fix: description of config options (streamlit#6917)
  Add missing border radius (streamlit#6944)
  Up version to 1.24.0 (streamlit#6905)
  modify st.echo to use ast to handle indenting properly (streamlit#5375)
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants