New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hamburger menu icon to overflow #6947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
Nit: Could you do a pass across the codebase to remove any reference to the "hamburger" menu and substitute it with main menu? Think this will avoid future confusion.
@mayagbarnes Sure can do! Updated on b1c5da2 |
* develop: Respect current existing env var in build_info.py (streamlit#6906) fix: frontend/package.json & frontend/yarn.lock to reduce vulnerabilities (streamlit#6959) Update hamburger menu icon to overflow (streamlit#6947) Fix: description of config options (streamlit#6917) Add missing border radius (streamlit#6944) Up version to 1.24.0 (streamlit#6905) modify st.echo to use ast to handle indenting properly (streamlit#5375)
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow ... dots icon, and fixes an issue with inconsistent hover states while we're at it.
Describe your changes
This PR makes a design change requested by @jrieke, updating our hamburger menu for an overflow
...
dots icon, and fixes an issue with inconsistent hover states while we're at it.Notion links
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.