Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code and Add rm commands to make clean #6980

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

sfc-gh-wihuang
Copy link
Contributor

Describe your changes

  • remove the pythonic compilation process of building @streamlit/lib
  • add rm -rf for app and lib

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?
    no

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@willhuang1997 willhuang1997 merged commit cf081f8 into develop Jul 10, 2023
60 checks passed
tconkling added a commit to tconkling/streamlit that referenced this pull request Jul 12, 2023
* develop:
  Feature: st.toast (streamlit#6783)
  Bump semver from 5.7.1 to 5.7.2 in /frontend (streamlit#6982)
  Add host communication e2e tests  (streamlit#6806)
  Re-add homepage to package.json (streamlit#6987)
  Remove unnecessary code and Add rm commands to make clean (streamlit#6980)
  Allow setting placeholder for st.selectbox (streamlit#6913)
  Allow setting placeholder for st.multiselect (streamlit#6901)
  Also use bottom padding in embedded mode for chat input (streamlit#6979)
  Feature/st lib (streamlit#6692)
  Remove unused import (streamlit#6977)
  Release 1.24.1 (streamlit#6965)
  Update st.audio/st.video docstrings (streamlit#6964)
  Slightly simplify bug report template (streamlit#6972)
  Fix baseweb warnings by using longhand properties (streamlit#6976)
@vdonato vdonato deleted the cleanup/st-lib branch November 1, 2023 23:57
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
…6980)

* Remove unnecessary rebuilding of @streamlit/lib

* Add extra cleaning for node_modules in lib and app for make clean

* Remove watch_frontend_lib.py

---------

Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
…6980)

* Remove unnecessary rebuilding of @streamlit/lib

* Add extra cleaning for node_modules in lib and app for make clean

* Remove watch_frontend_lib.py

---------

Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
…6980)

* Remove unnecessary rebuilding of @streamlit/lib

* Add extra cleaning for node_modules in lib and app for make clean

* Remove watch_frontend_lib.py

---------

Co-authored-by: willhuang1997 <willhuang1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants