Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown support for radio button labels #7018

Merged
merged 8 commits into from Jul 25, 2023
Merged

Conversation

mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Jul 14, 2023

Describe your changes

Allows markdown in the options of st.radio - the same ones as permitted in Radio's label, with the exception of links because it is a clickable element.

GitHub Issue Link (if applicable)

Closes #6085

Testing Plan

  • FE/JS unit tests: Re-wrote both Radio.test.tsx files to to RTL
  • E2E/Snapshot tests: Added snapshot test w/ markdown in radio options

Before:
BeforeRadioMarkdownScreenshot

After:
After - no links


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes marked this pull request as ready for review July 21, 2023 19:18
@mayagbarnes mayagbarnes merged commit 2cd6a80 into develop Jul 25, 2023
48 checks passed
@mayagbarnes mayagbarnes deleted the radio-markdown branch July 25, 2023 02:08
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
Allows markdown in the options of st.radio - the same ones as permitted in Radio's label, with the exception of links because it is a clickable element.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
Allows markdown in the options of st.radio - the same ones as permitted in Radio's label, with the exception of links because it is a clickable element.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
Allows markdown in the options of st.radio - the same ones as permitted in Radio's label, with the exception of links because it is a clickable element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown support for radio buttons
2 participants