Assorted visual tweaks #7050
Merged
Assorted visual tweaks #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
reviewed
Jul 21, 2023
frontend/lib/src/components/widgets/NumberInput/NumberInput.tsx
Outdated
Show resolved
Hide resolved
mayagbarnes
reviewed
Jul 21, 2023
mayagbarnes
reviewed
Jul 21, 2023
frontend/lib/src/components/widgets/NumberInput/NumberInput.test.tsx
Outdated
Show resolved
Hide resolved
mayagbarnes
approved these changes
Jul 21, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
* Update link color * Update sidebar bottom padding * Hide number input controls when size is too small * Remove tests * Add new JS test for small number inputs * Update e2e tests * Add missing number input tests * Update number input test * Override link color for a tag as well in globalStyles * Add modal snapshots * Move breakpoint value to primitives file * Update number input test * Revert global change for links
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
* Update link color * Update sidebar bottom padding * Hide number input controls when size is too small * Remove tests * Add new JS test for small number inputs * Update e2e tests * Add missing number input tests * Update number input test * Override link color for a tag as well in globalStyles * Add modal snapshots * Move breakpoint value to primitives file * Update number input test * Revert global change for links
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Update link color * Update sidebar bottom padding * Hide number input controls when size is too small * Remove tests * Add new JS test for small number inputs * Update e2e tests * Add missing number input tests * Update number input test * Override link color for a tag as well in globalStyles * Add modal snapshots * Move breakpoint value to primitives file * Update number input test * Revert global change for links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR addresses a handful of visual tweaks, namely:
-and+buttons forst.number_inputwhen its width is smaller than120px(reported by @jrieke).Closes #894
Before:
After:
Untitled.mp4
Notion links
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.