New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Pass additional color specifications to charts #7061
Conversation
6933c3a
to
6f56e72
Compare
Would it be sufficient to just add some headers to an already existing test and update that snapshot? Seems unnecessary to create two new tests when we are just adding some properties to customTheme.tsx imo. In addition, it would remove the barley Vega dataset and thus make the test code easier to read. |
Probably, but I haven't been able to simply add headers without disrupting the whole chart config (can't say altair charts are a strong suit I guess). Open to help on how to do so! In the meantime going to see if I can import it from |
Ah yeah removing the plain barcharts sounds like a good idea |
2ee8cd7
to
18b9445
Compare
@willhuang1997 Could you give this another look when you have a chance 😃 |
Handles column specification in altair charts by passing header defaults for fonts/colors to both default and streamlit chart themes in CustomTheme.tsx
Handles column specification in altair charts by passing header defaults for fonts/colors to both default and streamlit chart themes in CustomTheme.tsx
Handles column specification in altair charts by passing header defaults for fonts/colors to both default and streamlit chart themes in CustomTheme.tsx
Describe your changes
Handles
column
specification in altair charts by passing header defaults for fonts/colors to bothdefault
andstreamlit
chart themes inCustomTheme.tsx
Before:
After:
GitHub Issue Link (if applicable)
Closes #3343
Testing Plan