Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make background color transparent for tabs #7070

Merged
merged 1 commit into from Jul 25, 2023

Conversation

sfc-gh-jgarcia
Copy link
Contributor

@sfc-gh-jgarcia sfc-gh-jgarcia commented Jul 25, 2023

Describe your changes

This PR fixes #5707 by making the tabs background-color transparent by default.

Before:

202043415-bfb4db98-cc5e-4390-b3b6-8e307994416e

After:

Screenshot 2023-07-25 at 11 22 33 AM

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed: Bugfix, all tests are in place already
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LukasMasuch LukasMasuch merged commit d6d8f62 into develop Jul 25, 2023
59 of 60 checks passed
@vdonato vdonato deleted the background-color-for-tabs branch November 1, 2023 23:56
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs Styling - Background Colour Not Transparent
3 participants