Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st.radio - markdown enabled captions #7105

Merged
merged 16 commits into from Aug 18, 2023
Merged

st.radio - markdown enabled captions #7105

merged 16 commits into from Aug 18, 2023

Conversation

mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Aug 2, 2023

Describe your changes

st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options.
These captions support the same markdown as radio button labels (which also don't allow links).

  • Note for StreamlitMarkdown component - this also decouples font size from the link disabling behavior of the isButton prop. disableLinks now only disables links in allowed markdown, and largerLabel handles increased font size.

Testing Plan

  • Unit Tests (JS and/or Python) - Added Python & JS unit tests ✅
  • E2E Tests - Added e2e & snapshot tests ✅

@mayagbarnes mayagbarnes changed the title st.radio - adding captions enabled with markdown st.radio - adding markdown enabled captions Aug 2, 2023
@mayagbarnes mayagbarnes changed the title st.radio - adding markdown enabled captions st.radio - markdown enabled captions Aug 3, 2023
@mayagbarnes mayagbarnes marked this pull request as ready for review August 3, 2023 18:01
Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto change LGTM 👍

Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mayagbarnes mayagbarnes merged commit 7902bfd into develop Aug 18, 2023
49 checks passed
@mayagbarnes mayagbarnes deleted the radio-captions branch August 18, 2023 02:13
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options.
These captions support the same markdown as radio button labels (which also don't allow links).
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options.
These captions support the same markdown as radio button labels (which also don't allow links).
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options.
These captions support the same markdown as radio button labels (which also don't allow links).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants