New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
st.radio
- markdown enabled captions
#7105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
changed the title
st.radio - adding captions enabled with markdown
st.radio - adding markdown enabled captions
Aug 2, 2023
mayagbarnes
commented
Aug 3, 2023
frontend/lib/src/components/shared/StreamlitMarkdown/StreamlitMarkdown.tsx
Outdated
Show resolved
Hide resolved
mayagbarnes
changed the title
st.radio - adding markdown enabled captions
Aug 3, 2023
st.radio
- markdown enabled captions
mayagbarnes
commented
Aug 3, 2023
mayagbarnes
requested review from
vdonato,
LukasMasuch and
sfc-gh-mnowotka
as code owners
August 3, 2023 18:01
kajarenc
reviewed
Aug 4, 2023
kajarenc
reviewed
Aug 4, 2023
kajarenc
approved these changes
Aug 4, 2023
LukasMasuch
reviewed
Aug 4, 2023
LukasMasuch
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proto change LGTM 👍
mayagbarnes
force-pushed
the
radio-captions
branch
from
August 4, 2023 21:43
2e17f01
to
ce66a32
Compare
mayagbarnes
force-pushed
the
radio-captions
branch
from
August 16, 2023 21:07
7b4022c
to
a762520
Compare
mayagbarnes
force-pushed
the
radio-captions
branch
from
August 17, 2023 15:03
faad13d
to
787487d
Compare
LukasMasuch
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options. These captions support the same markdown as radio button labels (which also don't allow links).
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options. These captions support the same markdown as radio button labels (which also don't allow links).
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
st.radio - adding a keyword-only param that allows you to add captions/descriptions to radio button options. These captions support the same markdown as radio button labels (which also don't allow links).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
st.radio
- adding a keyword-only param that allows you to add captions/descriptions to radio button options.These captions support the same markdown as radio button labels (which also don't allow links).
StreamlitMarkdown
component - this also decouples font size from the link disabling behavior of theisButton
prop.disableLinks
now only disables links in allowed markdown, andlargerLabel
handles increased font size.Testing Plan