Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: add gray & rainbow to supported colors #7106

Merged
merged 6 commits into from Aug 4, 2023
Merged

Conversation

mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Aug 2, 2023

Describe your changes

Add gray & rainbow to extend supported markdown colors (currently blue, green, orange, red, violet)

Examples:
Screenshot 2023-08-02 at 9 31 44 AM
Screenshot 2023-08-02 at 11 49 38 AM

Testing Plan

  • Unit Tests (JS and/or Python) - ✅ Added FE unit tests to StreamlitMarkdown & converted to RTL
  • E2E Tests - ✅ Added to st.markdown
  • Manual Testing - Tested on Chrome, Safari, Edge & Firefox

Doc Links

Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mayagbarnes mayagbarnes merged commit 873a52e into develop Aug 4, 2023
58 of 61 checks passed
@mayagbarnes mayagbarnes deleted the text-colors branch August 4, 2023 01:01
mayagbarnes added a commit that referenced this pull request Aug 16, 2023
Update docstrings referencing colored text for the new colors - gray & rainbow. See PR #7106.
Also allow alternative spellings gray/grey to map to same color.
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
Add gray & rainbow to extend supported markdown colors (currently blue, green, orange, red, violet)
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
Update docstrings referencing colored text for the new colors - gray & rainbow. See PR streamlit#7106.
Also allow alternative spellings gray/grey to map to same color.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
Add gray & rainbow to extend supported markdown colors (currently blue, green, orange, red, violet)
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
Update docstrings referencing colored text for the new colors - gray & rainbow. See PR streamlit#7106.
Also allow alternative spellings gray/grey to map to same color.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
Add gray & rainbow to extend supported markdown colors (currently blue, green, orange, red, violet)
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
Update docstrings referencing colored text for the new colors - gray & rainbow. See PR streamlit#7106.
Also allow alternative spellings gray/grey to map to same color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants