Fix autofill browser by making sure we commit the value in text inputs #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
reviewed
Aug 11, 2023
vdonato
reviewed
Aug 11, 2023
vdonato
reviewed
Aug 11, 2023
vdonato
reviewed
Aug 11, 2023
vdonato
reviewed
Aug 12, 2023
vdonato
reviewed
Aug 12, 2023
vdonato
approved these changes
Aug 12, 2023
vdonato
reviewed
Aug 12, 2023
4 tasks
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
streamlit#7150) Describe your changes Change commitWidgetValue to take in dirty parameter as we need to change dirty to true when committing the widget value we need to commit the widget value because when autofill is done, the widget value is not committed as thus username will show up to be an empty string without interaction GitHub Issue Link (if applicable) streamlit#7101 streamlit#7084 Testing Plan Explanation of why no additional tests are needed Unit Tests (JS and/or Python) readded tests I deleted before with some slight additions E2E Tests Any manual testing needed? yes it doesn't seem very doable to test autofill functionality. However, I can probably add some tests for commit value being called Contribution License Agreement By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
streamlit#7150) Describe your changes Change commitWidgetValue to take in dirty parameter as we need to change dirty to true when committing the widget value we need to commit the widget value because when autofill is done, the widget value is not committed as thus username will show up to be an empty string without interaction GitHub Issue Link (if applicable) streamlit#7101 streamlit#7084 Testing Plan Explanation of why no additional tests are needed Unit Tests (JS and/or Python) readded tests I deleted before with some slight additions E2E Tests Any manual testing needed? yes it doesn't seem very doable to test autofill functionality. However, I can probably add some tests for commit value being called Contribution License Agreement By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
streamlit#7150) Describe your changes Change commitWidgetValue to take in dirty parameter as we need to change dirty to true when committing the widget value we need to commit the widget value because when autofill is done, the widget value is not committed as thus username will show up to be an empty string without interaction GitHub Issue Link (if applicable) streamlit#7101 streamlit#7084 Testing Plan Explanation of why no additional tests are needed Unit Tests (JS and/or Python) readded tests I deleted before with some slight additions E2E Tests Any manual testing needed? yes it doesn't seem very doable to test autofill functionality. However, I can probably add some tests for commit value being called Contribution License Agreement By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
GitHub Issue Link (if applicable)
#7101
#7084
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.