New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Toasts blocked by st.chat_input
#7204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
force-pushed
the
toast-chat-fix
branch
from
August 18, 2023 21:07
54e15c6
to
59d6155
Compare
bottom: toastAdjustment ? "45px" : "0px", | ||
// Toasts overlap chatInput container | ||
zIndex: 100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason for 100? Is that just a really high number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially because chatInputContainer is 99 lol
willhuang1997
approved these changes
Aug 18, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
z-index on st.chat_input container places it above toasts. Adjusting so toasts display above.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
z-index on st.chat_input container places it above toasts. Adjusting so toasts display above.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
z-index on st.chat_input container places it above toasts. Adjusting so toasts display above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
z-index on
st.chat_input
container places it above toasts. Adjusting so toasts display above.Current:
Revised:
Deployed test app:
https://toast-overlay.streamlit.app/
GitHub Issue Link (if applicable)
Closes #7115