Fix: st.pydeck_chart with invalid JSON
#7256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
changed the title
st. pydeck_chart with invalid JSONst.pydeck_chart with invalid JSON
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
Python's json.dumps does not produce completely valid JSON, which is what Pydeck uses. Using JSON5 to parse instead.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
Python's json.dumps does not produce completely valid JSON, which is what Pydeck uses. Using JSON5 to parse instead.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Python's json.dumps does not produce completely valid JSON, which is what Pydeck uses. Using JSON5 to parse instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Python's
json.dumpsdoes not produce completely valid JSON, which is what Pydeck uses. UsingJSON5to parse instead.GitHub Issue Link (if applicable)
Closes #5799
Testing Plan