Fix: Handle start_time changes in st.video
#7257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
commented
Aug 30, 2023
frontend/cypress/snapshots/linux/2x/st_video.spec.js/video-updated-start.snap.png
Outdated
Show resolved
Hide resolved
kajarenc
reviewed
Aug 31, 2023
| @@ -49,6 +49,11 @@ export default function Video({ | |||
|
|
|||
| if (videoNode) { | |||
| videoNode.addEventListener("loadedmetadata", setStartTime) | |||
|
|
|||
There was a problem hiding this comment.
In this case, we will always change the current time to the start time, even if a rerun happens while playing video.
I think it is a good idea that the new behavior is consistent with st.audio
There was a problem hiding this comment.
Makes sense - I followed st.audio pattern this time if you'd like to give it another look!
kajarenc
approved these changes
Aug 31, 2023
mayagbarnes
force-pushed
the
video-start
branch
from
c25e7d5
to
529cd51
Compare
sfc-gh-kjavadyan
approved these changes
Sep 1, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
Adds additional check to useEffect to handle changes in start_time for st.video
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
Adds additional check to useEffect to handle changes in start_time for st.video
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Adds additional check to useEffect to handle changes in start_time for st.video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds additional check to
useEffectto handle changes instart_timeforst.videoGitHub Issue Link (if applicable)
Closes #7126
Testing Plan