Fix trigger resets with fast reruns #7283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnOctopus
commented
Sep 6, 2023
| # Update ourselves with the new widget_states. The old widget states, | ||
| # used to skip callbacks if values haven't changed, are also preserved. | ||
| # Clear any triggers that weren't reset because the script was disconnected | ||
| self._reset_triggers() |
There was a problem hiding this comment.
As an alternative, I considered splitting on_script_finished in two, and calling the part with the trigger reset from request_stop, before the disconnect. I opted to do it here instead to be more sure that the reset will happen, and to avoid having to create a bunch of plumbing methods that now correspond to calling just one function on the actual session state.
AnOctopus
force-pushed
the
fix/fast-rerun-trigger-reset
branch
from
87e6233
to
1081c13
Compare
AnOctopus
changed the title
mayagbarnes
approved these changes
Sep 11, 2023
5 tasks
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resetting trigger values of session state before we copy in the new client state. If fast reruns is enabled, the old script run can't do its
on_script_finishedcleanup, because it has been disconnected. For removing stale widgets, that is mostly not a problem, but failing to reset triggers basically prevents buttons from working until the script cleanly finishes. Resetting duringon_script_will_rerunprevents this problem, making the behavior consistent with or without fast reruns.GitHub Issue Link (if applicable)
Fixes #6643
Testing Plan
Verified with manual tests. I should probably add an e2e regression test for this.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.