Add id to map api #7307
Merged
Add id to map api #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhuang1997
added
type:bug
AnOctopus
reviewed
Sep 11, 2023
lib/streamlit/elements/map.py
Outdated
Comment on lines
244
to
252
| deck_gl_json = to_deckgl_json( | ||
| data, latitude, longitude, size, color, map_style, zoom | ||
| ) | ||
| map_proto.json = deck_gl_json | ||
| map_proto.use_container_width = use_container_width | ||
| json_string = json.dumps(deck_gl_json) | ||
| json_bytes = json_string.encode("utf-8") | ||
| id = hashlib.md5(json_bytes).hexdigest() | ||
| map_proto.id = id |
There was a problem hiding this comment.
Might be good to move this to a marshall function, to mirror how the pydeck element does it.
AnOctopus
reviewed
Sep 11, 2023
lib/streamlit/elements/map.py
Outdated
| map_proto.use_container_width = use_container_width | ||
| json_string = json.dumps(deck_gl_json) | ||
| json_bytes = json_string.encode("utf-8") | ||
| id = hashlib.md5(json_bytes).hexdigest() |
There was a problem hiding this comment.
I would prefer the id field be named something that doesn't make it seem like this is a widget, but the pydeck element already calls it id, so changing it would be a big pain, and probably not worth it.
AnOctopus
approved these changes
Sep 11, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
4 tasks
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
GitHub Issue Link (if applicable)
Testing Plan
Screen.Recording.2023-09-11.at.9.58.26.AM.mov
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.