Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update st.tabs visuals to make stale tabs more obvious #7310

Merged
merged 5 commits into from Sep 13, 2023

Conversation

mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Sep 12, 2023

Describe your changes

Update Tabs.tsx to have child elements render as stale/disabled when the tab is stale/disabled so it is more obvious to the user they are in process of being removed.

Updated:
Screenshot 2023-09-13 at 10 43 09 AM

GitHub Issue Link (if applicable)

Closes #7040

Testing Plan

  • Unit Tests (JS and/or Python) - Converted to RTL ✅
  • Manually tested ✅

@mayagbarnes mayagbarnes merged commit a8c6460 into develop Sep 13, 2023
50 checks passed
@mayagbarnes mayagbarnes deleted the fix-7040 branch September 13, 2023 23:04
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
…lit#7310)

Update Tabs.tsx to have child elements render as stale/disabled when the tab is stale/disabled so it is more obvious to the user they are in process of being removed.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
…lit#7310)

Update Tabs.tsx to have child elements render as stale/disabled when the tab is stale/disabled so it is more obvious to the user they are in process of being removed.
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
…lit#7310)

Update Tabs.tsx to have child elements render as stale/disabled when the tab is stale/disabled so it is more obvious to the user they are in process of being removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost tabs remain if the tab contents take too long to compute
2 participants