Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bokeh slider by adding in side effects to package json #7441

Merged
merged 11 commits into from Sep 29, 2023
Merged

Fix bokeh slider by adding in side effects to package json #7441

merged 11 commits into from Sep 29, 2023

Conversation

willhuang1997
Copy link
Collaborator

@willhuang1997 willhuang1997 commented Sep 27, 2023 •
edited

Describe your changes

  • need to add an exception to sideEffects in package.json as we are doing side effect imports in BokehChart.tsx
  • add a test in e2e to make sure this regression doesn't happen
  • migrate e2e cypress test to playwright

GitHub Issue Link (if applicable)

closes #7171

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
    • not sure of how to add a unit test for this
  • E2E Tests
    • added a test
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@willhuang1997 willhuang1997 marked this pull request as ready for review September 28, 2023 00:41
@sfc-gh-wihuang sfc-gh-wihuang merged commit 03b9781 into develop Sep 29, 2023
50 checks passed
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
@willhuang1997 @eric-skydio
Fix bokeh widgets by adding in side effects to package json (streamli…
c686694 
…t#7441)
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
@willhuang1997
Fix bokeh widgets by adding in side effects to package json (streamli…
cd67e9f 
…t#7441)
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
@willhuang1997 @zyxue
Fix bokeh widgets by adding in side effects to package json (streamli…
f386855 
…t#7441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcgrady kmcgrady kmcgrady approved these changes

Assignees
No one assigned
Labels
change:bugfix impact:users security-assessment-completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bokeh Sliders cause JS errors in browser console
3 participants
@willhuang1997 @kmcgrady @sfc-gh-wihuang